From: Dan Carpenter <error27@gmail.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@infradead.org>,
"David Härdeman" <david@hardeman.nu>,
"Jarod Wilson" <jarod@redhat.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: rc: ir-lirc-codec: fix potential integer overflow
Date: Thu, 2 Dec 2010 07:51:26 +0300 [thread overview]
Message-ID: <20101202045126.GA1784@bicker> (raw)
On Fri, Nov 26, 2010 at 08:06:35PM +0300, Vasiliy Kulikov wrote:
> count = n / sizeof(int);
> - if (count > LIRCBUF_SIZE || count % 2 == 0)
> + if (count > LIRCBUF_SIZE || count % 2 == 0 || n % sizeof(int) != 0)
^^^^^^^^^^^^^^^^^^^^
Wait, what? We just checked this a couple lines before.
The rest of the patch is right and a clever catch. It would affect
x86_64 systems and not i386. This doesn't have security implications
does it? You'd just catch the kmalloc() stack trace for insanely large
allocations.
regards,
dan carpenter
next reply other threads:[~2010-12-02 4:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 4:51 Dan Carpenter [this message]
2010-12-02 15:00 ` [PATCH] media: rc: ir-lirc-codec: fix potential integer overflow Jarod Wilson
2010-12-02 18:55 ` Jarod Wilson
2010-12-04 21:05 ` [PATCH v2] media: rc: ir-lirc-codec: fix " Vasiliy Kulikov
2010-12-08 16:15 ` Jarod Wilson
-- strict thread matches above, loose matches on Subject: below --
2010-12-02 21:08 [PATCH] media: rc: ir-lirc-codec: fix potential " Andy Walls
2010-11-26 17:06 Vasiliy Kulikov
2010-12-02 2:47 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202045126.GA1784@bicker \
--to=error27@gmail.com \
--cc=david@hardeman.nu \
--cc=jarod@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox