From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: linux-kernel@vger.kernel.org, lrg@slimlogic.co.uk,
dahuang@nvidia.com, olofj@chromium.org
Subject: Re: [PATCH 0/4] Various tps6586x regulator fixes from ChromeOS
Date: Thu, 2 Dec 2010 09:40:39 +0000 [thread overview]
Message-ID: <20101202094038.GA19267@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1291235851-29523-1-git-send-email-swarren@nvidia.com>
On Wed, Dec 01, 2010 at 01:37:27PM -0700, Stephen Warren wrote:
> Following are some patches for the tps6586x regulator driver that were
> made in the ChromeOS repository.
>
> A variety of people have built a kernel containing these patches, and
> booted Tegra Seaboard with that kernel.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
In general please do try to provide a bit more detail in your changelogs
- things like missing shifts are fairly obvious but...
> regulator: tps6586x: Fix TPS6586X_DVM to store goreg/bit
> regulator: tps6586x: Handle both enable reg/bits being the same
...things like these aren't obvious.
Please also note that the kernel does not use Gerritt.
next prev parent reply other threads:[~2010-12-02 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 20:37 [PATCH 0/4] Various tps6586x regulator fixes from ChromeOS Stephen Warren
2010-12-01 20:37 ` [PATCH 1/4] regulator: tps6586x: Add missing bit mask generation Stephen Warren
2010-12-01 20:37 ` [PATCH 2/4] regulator: tps6586x: Fix TPS6586X_DVM to store goreg/bit Stephen Warren
2010-12-01 20:37 ` [PATCH 3/4] regulator: tps6586x: Handle both enable reg/bits being the same Stephen Warren
2010-12-01 20:37 ` [PATCH 4/4] regulator: tps6586x: correct register table Stephen Warren
2010-12-02 9:40 ` Mark Brown [this message]
2010-12-02 11:28 ` [PATCH 0/4] Various tps6586x regulator fixes from ChromeOS Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202094038.GA19267@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dahuang@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=olofj@chromium.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox