Re: edac_core: crashes on shutdown

Borislav Petkov
2010-12-02T18:37:45Z

On Thu, Dec 02, 2010 at 01:05:01PM -0500, Tobias Karnat wrote:
> This patch fixed it.
> I have rebooted five times and it does not crash anymore.
>
> Thank you.

Thanks for testing and taking pictures :). I'll send it to Linus before
.37 is out.

> Btw, are there any information available regarding the NMI option?
>
> parm: edac_op_state:EDAC Error Reporting state: 0=Poll,1=NMI (int)
>
> In edac.txt NMI is listed under FUTURE HARDWARE SCANNING.

Well, looking at <arch/x86/kernel/traps.c:mem_parity_error()> this
should already work. But it is kinda of a hack, if I'm reading Doug
correctly: http://lkml.org/lkml/2010/9/21/144

And yes, using some kind of an interrupt is much better than polling but
I don't know whether there's a single interrupt source for the error
types all edac drivers can decode and report. In the amd64_edac case,
we're piggybacking on MCE, for example. This was actually the initial
reason for 00740c58541b6087d78418cebca1fcb86dc6077d and dropping polling
from that driver.

Doug, any additions?

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632