From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758261Ab0LCBDi (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Dec 2010 20:03:38 -0500
Received: from smtp1.linux-foundation.org ([140.211.169.13]:56383 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1758190Ab0LCBDh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Dec 2010 20:03:37 -0500
Date: Thu, 2 Dec 2010 17:02:54 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hughd@google.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        Kernel development list <linux-kernel@vger.kernel.org>,
        Ondrej Zary <linux@rainbow-software.org>,
        Linux-pm mailing list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] PM / Hibernate: Fix memory corruption related to swap
Message-Id: <20101202170254.25ec5941.akpm@linux-foundation.org>
In-Reply-To: <alpine.LSU.2.00.1012021622370.26812@tigran.mtv.corp.google.com>
References: <201012030040.37273.rjw@sisk.pl>
	<20101202155453.92e8ca57.akpm@linux-foundation.org>
	<alpine.LSU.2.00.1012021622370.26812@tigran.mtv.corp.google.com>
X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2 Dec 2010 16:37:21 -0800 (PST)
Hugh Dickins <hughd@google.com> wrote:

> On Thu, 2 Dec 2010, Andrew Morton wrote:
> > On Fri, 3 Dec 2010 00:40:36 +0100
> > "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > > 
> > > This patch is a fix for a regression and nasty memory corruption, so I'd like
> > > to push it to Linus for 2.6.37 if there are no objections.
> 
> (It will need backport to 2.6.35-stable and 2.6.36-stable:
> IIRC it doesn't quite apply cleanly to those, so we'll need
> to send a separate version.)
> 
> > 
> > It looks OK to me for 2.6.37 but for 2.6.38 please let's make
> > everything here a 100% no-op for CONFIG_PM_SLEEP=n builds. 
> > Specifically the slight overhead in __alloc_pages_nodemask.
> 
> I expect you're right that the CONFIG_PM would better be CONFIG__PM_SLEEP;
> but I think you misunderstand gfp_allowed_mask in __alloc_pages_nodemask:
> it came from slab & slub, to fix some early bootup issues, and predates
> Rafael's recent use of it in suspend and hibernation.
> 
> > 
> > Because given the global nature of saved_gfp_mask and the unlocked way
> > in which it is accessed, this facility won't be at all useful for
> > anything other than suspend.
> 
> ... and bootup.
> 

Oh.  Who writes this crap :(