From: Florian Mickler <florian@mickler.org>
To: Tobias Karnat <tobias.karnat@googlemail.com>
Cc: Borislav Petkov <bp@alien8.de>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: edac_core: crashes on shutdown
Date: Thu, 2 Dec 2010 18:02:52 +0100 [thread overview]
Message-ID: <20101202180252.05080815@schatten.dmk.lab> (raw)
In-Reply-To: <1291306872.3898.7.camel@Tobias-Karnat>
On Thu, 02 Dec 2010 17:21:12 +0100
Tobias Karnat <tobias.karnat@googlemail.com> wrote:
> Am Donnerstag, den 02.12.2010, 16:21 +0100 schrieb Borislav Petkov:
> > Well, thanks for the photos. I don't have an idea what might cause this
> > workqueue corruption I'm seeing, all reg/unreg paths look ok. The only
> > change that came in between .35 and .36.1 I can think of being relevant
> > is 00740c58541b6087d78418cebca1fcb86dc6077d. You could try backing that
> > one out to see whether it fixes the issue.
>
> Yes, reverting this fixed the issue!
>
> But why?
>
> -Tobias
>
>
It doesnt work because op_state is set to OP_OFFLINE in edac_mc_del_mc
before calling edac_mc_workq_teardown. Or am I seeing things?
<snip>
577 struct mem_ctl_info *edac_mc_del_mc(struct device *dev)
578 {
<snip>
592 /* marking MCI offline */
593 mci->op_state = OP_OFFLINE;
594
595 del_mc_from_global_list(mci);
596 mutex_unlock(&mem_ctls_mutex);
597
598 /* flush workq processes and remove sysfs */
599 edac_mc_workq_teardown(mci);
<snip>
Probably a better check in _teardown is on a bool that get's set in
edac_mc_workq_setup...?
next prev parent reply other threads:[~2010-12-02 17:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 11:01 edac_core: crashes on shutdown Tobias Karnat
2010-12-01 12:39 ` Borislav Petkov
2010-12-01 13:24 ` Tobias Karnat
2010-12-01 14:33 ` Borislav Petkov
2010-12-01 17:46 ` Tobias Karnat
2010-12-01 19:35 ` Borislav Petkov
2010-12-02 9:03 ` Tobias Karnat
2010-12-02 14:51 ` Florian Mickler
2010-12-02 14:52 ` Florian Mickler
2010-12-02 15:21 ` Borislav Petkov
2010-12-02 16:21 ` Tobias Karnat
2010-12-02 17:02 ` Florian Mickler [this message]
2010-12-02 17:07 ` Borislav Petkov
2010-12-02 17:06 ` Borislav Petkov
2010-12-02 18:05 ` Tobias Karnat
2010-12-02 18:37 ` Borislav Petkov
2010-12-02 22:34 ` Tobias Karnat
2010-12-03 11:58 ` Borislav Petkov
2010-12-03 21:23 ` Doug Thompson
2010-12-02 18:14 ` Florian Mickler
2010-12-02 18:51 ` Borislav Petkov
2010-12-02 19:54 ` Florian Mickler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202180252.05080815@schatten.dmk.lab \
--to=florian@mickler.org \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tobias.karnat@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox