Re: [PATCH] [USB] UAS: Rename urbs by pipe

Luben Tuikov
2010-10-28T21:43:39Z

--- On Thu, 10/28/10, Greg KH <greg@kroah.com> wrote:
> I'm sorry, but can you explain this a bit more?  I
> really don't
> understand why this change is necessary.

It isn't necessary (like water or food, etc). It reflects much closer what
really is happening under the hood. Having a software abstraction
(implementation) representing the hw or the physical function much closer,
allows for much more versatile manipulation.

For example, if you would like to implement sending TMFs and receiving
their Responses, you'd do that on the Command and Status pipes. So you can
allocate an URB at the "cmd_urb" (meaning "command pipe urb") and on the
"status_urb" (meaning "status pipe urb"). Before this patch this was called
"sense_urb" which reflected what the type of IU but not the pipe, all the
while it was being allocated for the Status pipe. A good infrastructure
is a reusable infrastructure. This patch properly renames some macro
definitions and variables in order to allow for some of the infrastructure
of the driver to be reused in order to send other IUs.