Re: [PATCH] Fix coding style issues in drivers.c

[Greg KH <gregkh@suse.de>]

On Fri, Dec 03, 2010 at 11:31:17PM +0200, Xenofon Foukas wrote:
> This patch fixes line over 80 characters warning issues found
> in file drivers.c
> Signed-off-by: Xenofon Foukas <foukas.xenofon@gmail.com>
> ---
>  drivers/staging/comedi/drivers.c |   26 ++++++++++++++++++--------
>  1 files changed, 18 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
> index 4a29ed7..840b7e0 100644
> --- a/drivers/staging/comedi/drivers.c
> +++ b/drivers/staging/comedi/drivers.c
> @@ -118,7 +118,8 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  	for (driv = comedi_drivers; driv; driv = driv->next) {
>  		if (!try_module_get(driv->module)) {
>  			printk
> -			    (KERN_INFO "comedi: failed to increment module count, skipping\n");
> +			     (KERN_INFO "comedi: failed to increment "
> +						"module count, skipping\n");

No, put this all on one line, with the printk() and the warning will go
away.

Care to fix this for the other printk() change you did in this file and
resend it?

thanks,

greg k-h