public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: Hold client_mutex while calling snd_soc_instantiate_cards()
@ 2010-12-06  8:48 Axel Lin
  2010-12-06 12:36 ` Liam Girdwood
  2010-12-06 12:55 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2010-12-06  8:48 UTC (permalink / raw)
  To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, alsa-devel

As the comments of snd_soc_instantiate_cards() said,
snd_soc_instantiate_cards() must be called with client_mutex.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 sound/soc/soc-core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index eb950f7..0d69b91 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -3299,7 +3299,9 @@ int snd_soc_register_dais(struct device *dev,
 		pr_debug("Registered DAI '%s'\n", dai->name);
 	}
 
+	mutex_lock(&client_mutex);
 	snd_soc_instantiate_cards();
+	mutex_unlock(&client_mutex);
 	return 0;
 
 err:
-- 
1.7.2




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Hold client_mutex while calling snd_soc_instantiate_cards()
  2010-12-06  8:48 [PATCH] ASoC: Hold client_mutex while calling snd_soc_instantiate_cards() Axel Lin
@ 2010-12-06 12:36 ` Liam Girdwood
  2010-12-06 12:55 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-12-06 12:36 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Mark Brown, alsa-devel

On Mon, 2010-12-06 at 16:48 +0800, Axel Lin wrote:
> As the comments of snd_soc_instantiate_cards() said,
> snd_soc_instantiate_cards() must be called with client_mutex.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Hold client_mutex while calling snd_soc_instantiate_cards()
  2010-12-06  8:48 [PATCH] ASoC: Hold client_mutex while calling snd_soc_instantiate_cards() Axel Lin
  2010-12-06 12:36 ` Liam Girdwood
@ 2010-12-06 12:55 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-12-06 12:55 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, alsa-devel

On Mon, Dec 06, 2010 at 04:48:03PM +0800, Axel Lin wrote:
> As the comments of snd_soc_instantiate_cards() said,
> snd_soc_instantiate_cards() must be called with client_mutex.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-06 12:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-06  8:48 [PATCH] ASoC: Hold client_mutex while calling snd_soc_instantiate_cards() Axel Lin
2010-12-06 12:36 ` Liam Girdwood
2010-12-06 12:55 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox