From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752685Ab0LFNj3 (ORCPT ); Mon, 6 Dec 2010 08:39:29 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:56470 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560Ab0LFNj1 (ORCPT ); Mon, 6 Dec 2010 08:39:27 -0500 Date: Mon, 6 Dec 2010 08:39:24 -0500 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , "Theodore Ts'o" , linux-kernel , linux-ext4 Subject: Re: [PATCH] ext4: Set barrier=0 when block device does not advertise flush support Message-ID: <20101206133924.GB9235@infradead.org> References: <20101203001659.GI18195@tux1.beaverton.ibm.com> <20101203070950.GA19071@infradead.org> <20101203091445.GK18195@tux1.beaverton.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101203091445.GK18195@tux1.beaverton.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org barrier=0 really means losemydata=1. The plan I discussed with Jens was to allow to disable the flush and fua semantics in the block layer, so we'll have one new tunable for that, which is documented to causes these issues. > picks the safe option by default. However, I'd prefer /proc/mounts not > misrepresent the status of flush support, to the best of ext4's knowledge. That's bullshit. The barrier option has traditionally meant that we sent barrier requests, and now means thatwe send flush+fua requests. There's no reason for a warning and option mislabling just because you got the most efficient implementation of it.