Re: [RFC] perf: Prevent potential null dereference

[Arnaldo Carvalho de Melo <acme@ghostprotocols.net>]

Em Mon, Dec 06, 2010 at 01:13:21AM +0300, Cyrill Gorcunov escreveu:
> On Thu, Dec 02, 2010 at 08:46:10PM -0200, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Dec 02, 2010 at 11:41:08PM +0100, Frederic Weisbecker escreveu:
> > > On Fri, Dec 03, 2010 at 01:26:05AM +0300, Cyrill Gorcunov wrote:
> > > > In case if there is no memory we might hit null
> > > > dereference on accessing calloc'ed data.
> > > > 
> > > > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> > > > CC: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > > CC: Peter Zijlstra <peterz@infradead.org>
> > > > CC: Ingo Molnar <mingo@elte.hu>
> > > > CC: Frederic Weisbecker <fweisbec@gmail.com>
> > > > ---
> ...
> > > 
> > > Good.
> > > 
> > > As a nit, not that it matters that much because we are very close to the starting code
> > > anyway, but it would be better to propagate the error to the callers.
> > 
> > I'm of the opinion that main() should be where exit() is allowed, and
> > even there... return would be better. 8-)
> > 
> > - Arnaldo
> > 
> 
> ok, sorry for delay, it seems the following would be liked
> more than first version ;)
> 

Hey, what tree is this agains? I guess tip/master, right? If so, I still
didn't got there :-\

- Arnaldo