From: Christoph Lameter <cl@linux.com>
To: Tejun Heo <tj@kernel.org>
Cc: akpm@linux-foundation.org, Wu Fengguang <fengguang.wu@intel.com>,
Christoph Hellwig <hch@lst.de>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: [cpuops inc_return V1 7/9] fs: Use this_cpu_inc_return in buffer.c
Date: Mon, 06 Dec 2010 11:40:05 -0600 [thread overview]
Message-ID: <20101206174017.112009516@linux.com> (raw)
In-Reply-To: 20101206173958.685460926@linux.com
[-- Attachment #1: cpuops_inc_return_buffer --]
[-- Type: text/plain, Size: 832 bytes --]
__this_cpu_inc can create a single instruction with the same effect
as the _get_cpu_var(..)++ construct in buffer.c.
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christoph Lameter <cl@linux.com>
---
fs/buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/fs/buffer.c
===================================================================
--- linux-2.6.orig/fs/buffer.c 2010-12-06 10:56:21.000000000 -0600
+++ linux-2.6/fs/buffer.c 2010-12-06 10:56:26.000000000 -0600
@@ -3201,7 +3201,7 @@ static void recalc_bh_state(void)
int i;
int tot = 0;
- if (__get_cpu_var(bh_accounting).ratelimit++ < 4096)
+ if (__this_cpu_inc_return(bh_accounting.ratelimit) - 1 < 4096)
return;
__this_cpu_write(bh_accounting.ratelimit, 0);
for_each_online_cpu(i)
next prev parent reply other threads:[~2010-12-06 17:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 17:39 [cpuops inc_return V1 0/9] Implement this_cpu_inc_return (and friends) and use it in various places Christoph Lameter
2010-12-06 17:39 ` [cpuops inc_return V1 1/9] percpu: Generic support for this_cpu_add,sub,dec,inc_return Christoph Lameter
2010-12-08 16:15 ` [cpuops UPDATED " Tejun Heo
2010-12-06 17:40 ` [cpuops inc_return V1 2/9] x86: Support " Christoph Lameter
2010-12-08 16:44 ` [cpuops UPDATED 2/9] x86: Support for this_cpu_add, sub, dec, inc_return Tejun Heo
2010-12-06 17:40 ` [cpuops inc_return V1 3/9] x86: Use this_cpu_inc_return for nmi counter Christoph Lameter
2010-12-08 16:45 ` Tejun Heo
2010-12-08 17:31 ` Christoph Lameter
2010-12-08 17:45 ` Tejun Heo
2010-12-06 17:40 ` [cpuops inc_return V1 4/9] vmstat: Use this_cpu_inc_return for vm statistics Christoph Lameter
2010-12-06 17:40 ` [cpuops inc_return V1 5/9] highmem: Use this_cpu_xx_return() operations Christoph Lameter
2010-12-06 17:40 ` [cpuops inc_return V1 6/9] Taskstats: Use this_cpu_ops Christoph Lameter
2010-12-07 9:35 ` Michael Holzheu
2010-12-07 14:45 ` Christoph Lameter
2010-12-06 17:40 ` Christoph Lameter [this message]
2010-12-06 17:40 ` [cpuops inc_return V1 8/9] random: Use this_cpu_inc_return Christoph Lameter
2010-12-06 18:11 ` Matt Mackall
2010-12-06 18:29 ` Christoph Lameter
2010-12-06 17:40 ` [cpuops inc_return V1 9/9] Xen: " Christoph Lameter
2010-12-07 15:46 ` Straggler: Connector: Use this_cpu_operations Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206174017.112009516@linux.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hch@lst.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox