public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Tejun Heo <tj@kernel.org>
Cc: akpm@linux-foundation.org,
	Richard Kennedy <richard@rsk.demon.co.uk>,
	Matt Mackall <mpm@selenic.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: [cpuops inc_return V1 8/9] random: Use this_cpu_inc_return
Date: Mon, 06 Dec 2010 11:40:06 -0600	[thread overview]
Message-ID: <20101206174017.684979312@linux.com> (raw)
In-Reply-To: 20101206173958.685460926@linux.com

[-- Attachment #1: cpuops_inc_return_random --]
[-- Type: text/plain, Size: 906 bytes --]

__this_cpu_inc can create a single instruction to do the same as
__get_cpu_var()++.

Cc: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: Matt Mackall <mpm@selenic.com>
Signed-off-by: Christoph Lameter <cl@linux.com>

---
 drivers/char/random.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/char/random.c
===================================================================
--- linux-2.6.orig/drivers/char/random.c	2010-12-06 11:01:06.000000000 -0600
+++ linux-2.6/drivers/char/random.c	2010-12-06 11:19:38.000000000 -0600
@@ -626,7 +626,7 @@ static void add_timer_randomness(struct
 	preempt_disable();
 	/* if over the trickle threshold, use only 1 in 4096 samples */
 	if (input_pool.entropy_count > trickle_thresh &&
-	    (__get_cpu_var(trickle_count)++ & 0xfff))
+	    ((__this_cpu_inc_return(trickle_count) - 1) & 0xfff))
 		goto out;
 
 	sample.jiffies = jiffies;


  parent reply	other threads:[~2010-12-06 17:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 17:39 [cpuops inc_return V1 0/9] Implement this_cpu_inc_return (and friends) and use it in various places Christoph Lameter
2010-12-06 17:39 ` [cpuops inc_return V1 1/9] percpu: Generic support for this_cpu_add,sub,dec,inc_return Christoph Lameter
2010-12-08 16:15   ` [cpuops UPDATED " Tejun Heo
2010-12-06 17:40 ` [cpuops inc_return V1 2/9] x86: Support " Christoph Lameter
2010-12-08 16:44   ` [cpuops UPDATED 2/9] x86: Support for this_cpu_add, sub, dec, inc_return Tejun Heo
2010-12-06 17:40 ` [cpuops inc_return V1 3/9] x86: Use this_cpu_inc_return for nmi counter Christoph Lameter
2010-12-08 16:45   ` Tejun Heo
2010-12-08 17:31     ` Christoph Lameter
2010-12-08 17:45       ` Tejun Heo
2010-12-06 17:40 ` [cpuops inc_return V1 4/9] vmstat: Use this_cpu_inc_return for vm statistics Christoph Lameter
2010-12-06 17:40 ` [cpuops inc_return V1 5/9] highmem: Use this_cpu_xx_return() operations Christoph Lameter
2010-12-06 17:40 ` [cpuops inc_return V1 6/9] Taskstats: Use this_cpu_ops Christoph Lameter
2010-12-07  9:35   ` Michael Holzheu
2010-12-07 14:45     ` Christoph Lameter
2010-12-06 17:40 ` [cpuops inc_return V1 7/9] fs: Use this_cpu_inc_return in buffer.c Christoph Lameter
2010-12-06 17:40 ` Christoph Lameter [this message]
2010-12-06 18:11   ` [cpuops inc_return V1 8/9] random: Use this_cpu_inc_return Matt Mackall
2010-12-06 18:29     ` Christoph Lameter
2010-12-06 17:40 ` [cpuops inc_return V1 9/9] Xen: " Christoph Lameter
2010-12-07 15:46 ` Straggler: Connector: Use this_cpu_operations Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101206174017.684979312@linux.com \
    --to=cl@linux.com \
    --cc=akpm@linux-foundation.org \
    --cc=mpm@selenic.com \
    --cc=richard@rsk.demon.co.uk \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox