From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>,
linux-kernel@vger.kernel.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH 29/29] drivers/regulator: Update WARN uses
Date: Tue, 7 Dec 2010 11:43:46 +0000 [thread overview]
Message-ID: <20101207114346.GC10722@sirena.org.uk> (raw)
In-Reply-To: <b0588ea464d551f9dbd80c0fee68a780d6279b50.1291670106.git.joe@perches.com>
On Mon, Dec 06, 2010 at 02:05:19PM -0800, Joe Perches wrote:
> Align arguments.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
but please do remember to send patches to maintainers - trying to merge
patches without going through the maintainers means that people working
on the actual tree concerned may either replicate your work or introduce
conflicts with your patches, neither of which is good.
Not cutting the patch for Liam's benefit:
> ---
> drivers/regulator/core.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index a1b1237..5d07e5d 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1379,8 +1379,7 @@ static int _regulator_disable(struct regulator_dev *rdev,
> *supply_rdev_ptr = NULL;
>
> if (WARN(rdev->use_count <= 0,
> - "unbalanced disables for %s\n",
> - rdev_get_name(rdev)))
> + "unbalanced disables for %s\n", rdev_get_name(rdev)))
> return -EIO;
>
> /* are we the last user and permitted to disable ? */
> --
> 1.7.3.2.245.g03276.dirty
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
"You grabbed my hand and we fell into it, like a daydream - or a fever."
next prev parent reply other threads:[~2010-12-07 11:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 22:04 [PATCH 00/29] trivial: WARN cleanups Joe Perches
2010-12-06 22:04 ` [PATCH 01/29] include/asm-generic/bug.h: Update WARN macros Joe Perches
2010-12-06 22:04 ` [PATCH 02/29] arch/alpha: Update WARN uses Joe Perches
2010-12-06 22:04 ` [PATCH 03/29] arch/arm: " Joe Perches
2010-12-06 22:04 ` [PATCH 04/29] arch/powerpc: " Joe Perches
2010-12-06 22:04 ` [PATCH 05/29] arch/x86: " Joe Perches
2010-12-06 22:04 ` [PATCH 06/29] drivers/acpi: " Joe Perches
2010-12-06 22:04 ` [PATCH 07/29] drivers/base: " Joe Perches
2010-12-06 22:04 ` [PATCH 08/29] drivers/block: " Joe Perches
2010-12-06 22:04 ` [PATCH 09/29] drivers/cpuidle: " Joe Perches
2010-12-06 22:05 ` [PATCH 10/29] drivers/firmware: " Joe Perches
2010-12-06 22:05 ` [PATCH 11/29] drivers/gpio: " Joe Perches
2010-12-06 22:05 ` [PATCH 12/29] drivers/net/wireless/iwlwifi: " Joe Perches
2010-12-06 22:05 ` [PATCH 13/29] drivers/scsi/fcoe: " Joe Perches
2010-12-06 22:05 ` [PATCH 14/29] drivers/usb/musb: " Joe Perches
2010-12-06 22:05 ` [PATCH 15/29] drivers/video/omap2/dss: " Joe Perches
2010-12-06 22:05 ` [PATCH 16/29] fs/nfsd: " Joe Perches
2010-12-06 22:05 ` [PATCH 17/29] fs/notify/inotify: " Joe Perches
2010-12-06 22:05 ` [PATCH 18/29] fs/sysfs: " Joe Perches
2010-12-06 22:05 ` [PATCH 19/29] fs/proc: " Joe Perches
2010-12-06 22:05 ` [PATCH 20/29] fs: " Joe Perches
2010-12-06 22:05 ` [PATCH 21/29] include/linux/device.h: " Joe Perches
2010-12-06 22:05 ` [PATCH 22/29] kernel/irq: " Joe Perches
2010-12-06 22:05 ` [PATCH 23/29] kernel/panic.c: Update warn_slowpath to use %pV Joe Perches
2010-12-06 22:05 ` [PATCH 24/29] kernel: Update WARN uses Joe Perches
2010-12-06 22:05 ` [PATCH 25/29] lib: " Joe Perches
2010-12-06 22:05 ` [PATCH 26/29] mm: " Joe Perches
2010-12-06 22:05 ` [PATCH 27/29] net/mac80211: " Joe Perches
2010-12-06 22:05 ` [PATCH 28/29] net/rfkill/input.c: " Joe Perches
2010-12-06 22:05 ` [PATCH 29/29] drivers/regulator: " Joe Perches
2010-12-07 11:43 ` Mark Brown [this message]
2010-12-07 14:50 ` Jiri Kosina
2010-12-07 15:16 ` Mark Brown
2010-12-07 15:31 ` Jiri Kosina
2010-12-07 15:44 ` Liam Girdwood
2010-12-09 9:10 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207114346.GC10722@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox