From: Andrew Morton <akpm@linux-foundation.org>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: Linux Containers <containers@lists.osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH] user_ns: Improve the user_ns on-the-slab packaging
Date: Tue, 7 Dec 2010 14:13:15 -0800 [thread overview]
Message-ID: <20101207141315.5ea45abf.akpm@linux-foundation.org> (raw)
In-Reply-To: <4CFE40D1.5000309@parallels.com>
On Tue, 07 Dec 2010 17:12:33 +0300
Pavel Emelyanov <xemul@parallels.com> wrote:
> @@ -126,3 +128,11 @@ gid_t user_ns_map_gid(struct user_namespace *to, const struct cred *cred, gid_t
> /* No useful relationship so no mapping */
> return overflowgid;
> }
> +
> +static __init int user_namespaces_init(void)
> +{
> + user_ns_cachep = KMEM_CACHE(user_namespace, SLAB_PANIC);
> + return 0;
> +}
> +
> +__initcall(user_namespaces_init);
checkpatch (which you apparently didn't use) says
WARNING: please use device_initcall() instead of __initcall()
#81: FILE: kernel/user_namespace.c:138:
+__initcall(user_namespaces_init);
which was a somewhat random recommendation. I think I'll switch it to
plain old module_init().
Presumably user-namespaces don't get used prior to initcalls being run.
prev parent reply other threads:[~2010-12-07 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 14:12 [PATCH] user_ns: Improve the user_ns on-the-slab packaging Pavel Emelyanov
2010-12-07 14:27 ` Serge E. Hallyn
2010-12-07 14:33 ` Pavel Emelyanov
2010-12-07 14:50 ` Serge E. Hallyn
2010-12-07 22:13 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207141315.5ea45abf.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox