Re: [PATCH] VMware balloon: stop locking pages when hypervisor tells us enough

[Dmitry Torokhov <dtor@vmware.com>]

On Tuesday, December 07, 2010 05:10:23 pm Andrew Morton wrote:
> On Fri, 3 Dec 2010 08:52:26 -0800
> 
> Dmitry Torokhov <dtor@vmware.com> wrote:
> > When hypervisor decides to decrease target balloon size while the
> > balloon driver tries to lock pages hypervisor may respond with
> > VMW_BALLOON_PPN_NOTNEEDED. Use this data and immediately stop reserving
> > pages and wait for the next update cycle to fetch new target instead
> > of continuing trying to lock pages until size of refused list grows
> > above VMW_BALLOON_MAX_REFUSED (16) pages.
> 
> OK, but ... why?  What is the externally visible effect of this change?

As a result the driver stops bothering hypervisor with its attempts to
lock more pages that are not needed anymore. Most likely next order from
hypervisor will be to reduce ballon size anyway.

It is a small optimization.

Thanks,

Dmitry