From: Andrew Morton <akpm@linux-foundation.org>
To: Daniel Drake <dsd@laptop.org>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org,
dilinger@queued.net
Subject: Re: [PATCH v5 resend] OLPC: Add XO-1 suspend/resume support
Date: Wed, 8 Dec 2010 15:05:36 -0800 [thread overview]
Message-ID: <20101208150536.91a5f83f.akpm@linux-foundation.org> (raw)
In-Reply-To: <AANLkTinh9RyGAKeL4weN5bWQ=pAn0NwKdb8Ru4RKkDP3@mail.gmail.com>
On Wed, 8 Dec 2010 22:56:50 +0000
Daniel Drake <dsd@laptop.org> wrote:
> > Also, this checkpatch warning
> >
> > WARNING: struct platform_suspend_ops should normally be const
> > #502: FILE: arch/x86/platform/olpc/xo1.c:106:
> > +static struct platform_suspend_ops xo1_suspend_ops = {
> >
> > seems valid.
>
> When you correct it (to make it const), gcc gives a warning, because
> suspend_set_ops() takes non-const arg.
suspend_set_ops() is fixed in linux-next.
prev parent reply other threads:[~2010-12-08 23:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 14:18 [PATCH v5 resend] OLPC: Add XO-1 suspend/resume support Daniel Drake
2010-12-06 21:31 ` Thomas Gleixner
2010-12-06 22:31 ` Rafael J. Wysocki
2010-12-08 22:50 ` Andrew Morton
2010-12-08 22:56 ` Daniel Drake
2010-12-08 23:05 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208150536.91a5f83f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox