From: Matthew Wilcox <matthew@wil.cx>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: James Bottomley <James.Bottomley@suse.de>,
Greg KH <greg@kroah.com>, Luben Tuikov <ltuikov@yahoo.com>,
Matthew Dharm <mdharm-kernel@one-eyed-alien.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH repost 3] [SCSI] Retrieve the Caching mode page
Date: Wed, 8 Dec 2010 09:00:28 -0700 [thread overview]
Message-ID: <20101208160028.GB21909@parisc-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1012081054160.1885-100000@iolanthe.rowland.org>
On Wed, Dec 08, 2010 at 10:57:46AM -0500, Alan Stern wrote:
> In the strictest sense, there's always a possibility that any change
> will crash _some_ device somewhere. In this case I believe the
> probability is very low. Luben's patch does not change the commands
> sent to a USB device; it only changes the kernel's interpretation of
> the data sent back. Unless things are terribly badly broken, this
> won't hurt.
It doesn't change the _discovery_ commands sent to the device, but (I
think ...) it will change the subsequent commands sent to the device;
eg we'll now send it SYNCHRONISE CACHE when we wouldn't have before.
I think it's low-risk too, and am in favour of seeing this patch applied.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2010-12-08 16:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 0:02 [PATCH repost 3] [SCSI] Retrieve the Caching mode page Luben Tuikov
2010-12-08 0:12 ` Greg KH
2010-12-08 5:05 ` James Bottomley
2010-12-08 8:01 ` Luben Tuikov
2010-12-08 15:16 ` Alan Stern
2010-12-08 15:43 ` James Bottomley
2010-12-08 15:57 ` Alan Stern
2010-12-08 16:00 ` Matthew Wilcox [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-05 20:53 Luben Tuikov
2010-11-23 8:43 Luben Tuikov
2010-11-22 16:56 Luben Tuikov
2010-11-22 17:07 ` Linus Torvalds
2010-11-22 19:02 ` Douglas Gilbert
2010-11-23 4:59 ` Matthew Dharm
2010-11-23 18:40 ` Douglas Gilbert
2010-11-22 20:02 ` Luben Tuikov
2010-11-23 5:00 ` Matthew Dharm
2010-11-23 9:25 ` Luben Tuikov
2010-11-23 14:30 ` Matthew Dharm
2010-11-24 9:02 ` Luben Tuikov
2010-11-24 10:10 ` James Bottomley
2010-11-24 14:48 ` Christoph Hellwig
2010-11-24 14:49 ` Alan Stern
2010-11-24 14:58 ` James Bottomley
2010-11-24 16:55 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208160028.GB21909@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@suse.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ltuikov@yahoo.com \
--cc=mdharm-kernel@one-eyed-alien.net \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox