From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ike Panhc <ike.pan@canonical.com>
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org,
Matthew Garrett <mjg@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: Re: [PATCH 4/7] ideapad: select INPUT_SPARSEKMAP
Date: Thu, 9 Dec 2010 00:13:30 -0800 [thread overview]
Message-ID: <20101209081329.GC6233@core.coreip.homeip.net> (raw)
In-Reply-To: <1291881440-4846-1-git-send-email-ike.pan@canonical.com>
On Thu, Dec 09, 2010 at 03:57:20PM +0800, Ike Panhc wrote:
> Thanks for Dave Hansen report the problem. If CONFIG_INPUT_SPARSEKMAP is not
> set, when building, you will have error message:
>
> ERROR: "sparse_keymap_setup" [drivers/platform/x86/ideapad-laptop.ko] undefined!
> ERROR: "sparse_keymap_free" [drivers/platform/x86/ideapad-laptop.ko] undefined!
> ERROR: "sparse_keymap_report_event" [drivers/platform/x86/ideapad-laptop.ko] undefined!
>
> To select INPUT_SPARSEKMAP solve this issue.
>
> Ref: http://lkml.org/lkml/2010/12/2/340
>
I'd recommend folding this patch together with the patch that introduces
sparse keymap usage. Leaving them separated served only to risk compile
errors during bisecting.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-12-09 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 7:56 [PATCH v2 0/7] ideapad: hotkey enablement Ike Panhc
2010-12-09 7:56 ` [PATCH 1/7] ideapad: add platform driver for ideapad Ike Panhc
2010-12-09 17:04 ` Dave Hansen
2010-12-09 7:56 ` [PATCH 2/7] ideapad: let camera power control entry under platform driver Ike Panhc
2010-12-09 7:57 ` [PATCH 3/7] ideapad: add hotkey support Ike Panhc
2010-12-09 7:57 ` [PATCH 4/7] ideapad: select INPUT_SPARSEKMAP Ike Panhc
2010-12-09 8:13 ` Dmitry Torokhov [this message]
2010-12-09 7:57 ` [PATCH 5/7] ideapad: add markups, unify comments and return result when init Ike Panhc
2010-12-09 7:57 ` [PATCH 6/7] ideapad: pass ideapad_priv as argument (part 1) Ike Panhc
2010-12-09 7:57 ` [PATCH 7/7] ideapad: pass ideapad_priv as argument (part 2) Ike Panhc
2010-12-09 8:39 ` [PATCH v2 0/7] ideapad: hotkey enablement Corentin Chary
2010-12-13 8:49 ` Ike Panhc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209081329.GC6233@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dave@linux.vnet.ibm.com \
--cc=dwmw2@infradead.org \
--cc=ike.pan@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox