From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: linux-kernel@vger.kernel.org
Subject: Re: format and standards issues fixes
Date: Thu, 9 Dec 2010 10:43:44 +0200 [thread overview]
Message-ID: <20101209084344.GA4987@core2.telecom.by> (raw)
In-Reply-To: <20101209073126.GA2212@debian.Jeff>
On Thu, Dec 09, 2010 at 01:01:26PM +0530, Jeffrin Jose wrote:
> @@ -152,15 +151,14 @@ extern int msnd_pinnacle_init(void);
> #ifdef CONFIG_SOUND_OSS_CORE_PRECLAIM
> static int preclaim_oss = 1;
> #else
> -static int preclaim_oss = 0;
> +static int preclaim_oss = -1;
You didn't understand that warning, do you?
> @@ -252,8 +248,9 @@ static DEFINE_SPINLOCK(sound_loader_lock);
> * list. Acquires locks as needed
> */
>
> -static int sound_insert_unit(struct sound_unit **list, const struct file_operations *fops, int index, int low, int top, const char *name, umode_t mode, struct device *dev)
> -{
> +static int sound_insert_unit(struct sound_unit **list, const struct \
> +file_operations *fops, int index, int low, int top, const char *name,\
> +umode_t mode, struct device *dev) {
You're splitting lines in unexpected places, so unexpected, that nobody
thought of them before.
prev parent reply other threads:[~2010-12-09 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 7:31 format and standards issues fixes Jeffrin Jose
2010-12-09 7:34 ` Pekka Enberg
2010-12-09 8:43 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209084344.GA4987@core2.telecom.by \
--to=adobriyan@gmail.com \
--cc=ahiliation@yahoo.co.in \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox