From: Florian Mickler <florian@mickler.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Asbjoern Sloth Toennesen <asbjorn@asbjorn.biz>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 6/7] e1000e: cleanup: swap arguments to avoid checkpatch errors
Date: Thu, 9 Dec 2010 11:34:16 +0100 [thread overview]
Message-ID: <20101209113416.66baf7ac@schatten.dmk.lab> (raw)
In-Reply-To: <1291865548.19763.1.camel@localhost>
On Thu, 09 Dec 2010 03:32:28 +0000
Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Thu, 2010-12-09 at 02:40 +0000, Asbjoern Sloth Toennesen wrote:
> > Swap argument order in order to avoid checkpatch treating it as an
> > unary operation, instead of an binary one, and obtain consistency
> > with the 3 other similar assignments in netdev.c (tdlen & rdlen).
> >
> > This patch fixes 3 checkpatch errors.
>
> You have got to be kidding. If the checkpatch warning offends you, fix
> the bug in checkpatch instead of changing perfectly good code.
>
> Ben.
That bug is fixed already:
https://patchwork.kernel.org/patch/299172/
Andrew picked it up.
Regards,
Flo
next prev parent reply other threads:[~2010-12-09 10:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 2:40 [PATCH 0/7] e1000e: cleanup Asbjoern Sloth Toennesen
2010-12-09 2:40 ` [PATCH 1/7] e1000e: cleanup: fix spacing issues Asbjoern Sloth Toennesen
2010-12-09 2:40 ` [PATCH 2/7] e1000e: cleanup: fix bracket issues Asbjoern Sloth Toennesen
2010-12-09 2:40 ` [PATCH 3/7] e1000e: cleanup: simplify E1000_ALL_* defines Asbjoern Sloth Toennesen
2010-12-09 2:40 ` [PATCH 4/7] e1000e: cleanup: fix long lines Asbjoern Sloth Toennesen
2010-12-09 3:34 ` Ben Hutchings
2010-12-09 2:40 ` [PATCH 5/7] e1000e: cleanup: fix space issues in ich8_* structs Asbjoern Sloth Toennesen
2010-12-09 2:40 ` [PATCH 6/7] e1000e: cleanup: swap arguments to avoid checkpatch errors Asbjoern Sloth Toennesen
2010-12-09 3:32 ` Ben Hutchings
2010-12-09 10:34 ` Florian Mickler [this message]
2010-12-09 2:40 ` [PATCH 7/7] e1000e: cleanup: fix copyright notices to preferred style Asbjoern Sloth Toennesen
2010-12-09 3:37 ` [PATCH 0/7] e1000e: cleanup Stephen Hemminger
2010-12-10 5:20 ` Kirsher, Jeffrey T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209113416.66baf7ac@schatten.dmk.lab \
--to=florian@mickler.org \
--cc=akpm@linux-foundation.org \
--cc=asbjorn@asbjorn.biz \
--cc=bhutchings@solarflare.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox