Re: [PATCH RFC] x86: initialize initial_page_table before paravirt jumps

Rusty Russell
2010-12-13T07:33:46Z

On Fri, 10 Dec 2010 04:22:24 am Jeremy Fitzhardinge wrote:
> On 12/08/2010 05:59 PM, Rusty Russell wrote:
> > As of v2.6.36-rc8-54-gb40827f, initial_page_table needs to be set up to boot.
> > My initial fix for lguest was to cut & paste in the initialization code, but
> > as it's simply byte-twiddling (which could be done at compile time if we
> > were clever enough), it seems better to do it unconditionally.
> >
> > Jeremy, Ingo does this make sense to you? Given it's rc5, I have an
> > lguest-specific patch ready as an alternative...
>
> We have already committed a Xen-specific fix for this (twice!). Your
> patch is a no-op for Xen because we never ended up using that entry path
> through head_32.S, so if it fixes things for lguest then go for it.

Hmm, I'm going to call that "Acked-by".

But given the late stage in the cycle, I'll put the lguest-only version in
now and submit this for next merge window.

Thanks!
Rusty.