From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757016Ab0LIUAr (ORCPT ); Thu, 9 Dec 2010 15:00:47 -0500 Received: from mail.openrapids.net ([64.15.138.104]:56017 "EHLO blackscsi.openrapids.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756985Ab0LIUAq (ORCPT ); Thu, 9 Dec 2010 15:00:46 -0500 Date: Thu, 9 Dec 2010 15:00:43 -0500 From: Mathieu Desnoyers To: Frederic Weisbecker Cc: Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, Li Zefan , William Cohen , "Jun'ichi Nomura" , "Theodore Ts'o" , Jason Baron , Mel Gorman , Eduard - Gabriel Munteanu , Marcelo Tosatti , Avi Kivity , Gleb Natapov , Hidetoshi Seto , Neil Horman , Arjan van de Ven , Peter Zijlstra , Kei Tokunaga , "Martin K. Petersen" , Oleg Nesterov , Masami Hiramatsu , Josh Stone , Xiao Guangrong , Thomas Gleixner , Zhaolei , Anton Blanchard Subject: Re: [RFC PATCH] ftrace trace event: introduce assignment macros Message-ID: <20101209200043.GA8448@Krystal> References: <20101209162210.GB6769@Krystal> <20101209170027.GF1712@nowhere> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101209170027.GF1712@nowhere> X-Editor: vi X-Info: http://www.efficios.com X-Operating-System: Linux/2.6.26-2-686 (i686) X-Uptime: 14:58:04 up 16 days, 1:01, 4 users, load average: 0.11, 0.03, 0.01 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Frederic Weisbecker (fweisbec@gmail.com) wrote: > On Thu, Dec 09, 2010 at 11:22:11AM -0500, Mathieu Desnoyers wrote: > > This patch proposes encapsulation of the raw assignments within TP_fast_assign() > > by introducing tp_assign() and tp_memcpy() macros. This will allow us to: > > > > - generically filter from input fields, > > - redefine the field write primitives. > > > > The current macros map directly to the old code. I changed the documentation in > > tracepoint.txt to reflect these new primitives, but all TRACE_EVENT() users > > should gradually update their code to use these macro wrappers rather than raw > > "=" assignments or mempcy() calls. > > [...] > > --- > > include/linux/tracepoint.h | 12 ++++++------ > > include/trace/ftrace.h | 6 ++++++ > > 2 files changed, 12 insertions(+), 6 deletions(-) > > > > Index: linux-2.6-lttng.git/include/trace/ftrace.h > > =================================================================== > > --- linux-2.6-lttng.git.orig/include/trace/ftrace.h > > +++ linux-2.6-lttng.git/include/trace/ftrace.h > > @@ -1,4 +1,10 @@ > > /* > > + * Macros mapping tp_assign() and tp_memcpy() to "=" and memcpy. > > + */ > > +#define tp_assign(dest, src) __entry->dest = src > > +#define tp_memcpy(dest, src, len) memcpy(__entry->dest, src, len) > > Looks good. Great! Can I resend it without "RFC" with your Acked-by ? If there is wide-spread agreement on this change, I might soon start rolling out patches that migrate TRACE_EVENT users to these new primitives. Thanks, Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com