Re: [PATCH] toshiba_acpi: FULL TOS1900 device support

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Azael,

On Fri, Dec 10, 2010 at 02:13:18PM -0700, Azael Avalos wrote:
>  	error = input_register_device(toshiba_acpi.hotkey_dev);
>  	if (error) {
>  		printk(MY_INFO "Unable to register input device\n");
> -		goto err_remove_notify;
> +		 goto err_free_keymap;

Extra space in indentation.

>  	}
> 
>  	return 0;
> 
> - err_remove_notify:
> -	acpi_remove_notify_handler(toshiba_acpi.handle,
> -				   ACPI_DEVICE_NOTIFY, toshiba_acpi_notify);
> - err_free_keymap:
> -	sparse_keymap_free(toshiba_acpi.hotkey_dev);
> - err_free_dev:
> +err_free_keymap:
> +	if (toshiba_acpi.hci_type == 2)
> +		i8042_remove_filter(toshiba_i8042_filter);
> +err_free_dev:
>  	input_free_device(toshiba_acpi.hotkey_dev);
>  	toshiba_acpi.hotkey_dev = NULL;
>  	return error;

I do not actually see you calling sparse_keymap_free() in the error path
anymore.

Thanks.

-- 
Dmitry