From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Igor Plyatov <plyatov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux@maxim.org.za,
nicolas.ferre@atmel.com, linux@arm.linux.org.uk,
costa.antonior@gmail.com, ryan@bluewatersys.com,
christian.glindkamp@taskit.de, pgsellmann@portner-elektronik.at
Subject: Re: [PATCH v4] mach-at91: Support for gsia18s board added
Date: Sun, 12 Dec 2010 01:50:48 +0100 [thread overview]
Message-ID: <20101212005048.GH19897@game.jcrosoft.org> (raw)
In-Reply-To: <1292000411-6691-1-git-send-email-plyatov@gmail.com>
On 20:00 Fri 10 Dec , Igor Plyatov wrote:
> The GS_IA18_S (GMS) is a carrier board from GeoSIG Ltd used with the
> Stamp9G20 SoM from Taskit company.
> It operate as an internet accelerometer.
>
> Signed-off-by: Igor Plyatov <plyatov@gmail.com>
> ---
> arch/arm/configs/gsia18s_defconfig | 147 +++++++
please no new defconfig
start to merge them
your patch contain a lots of whitespace please fix it
> +
> +/*
> + * Up to date linux/arch/arm/tools/mach-types database required to support this.
> +MACHINE_START(GSIA18S, "GS_IA18_S")
> +*/
> +MACHINE_START(STAMP9G20, "GS_IA18_S")
if you do this you must use system_rev to identify the board
> + .boot_params = AT91_SDRAM_BASE + 0x100,
> + .timer = &at91sam926x_timer,
> + .map_io = gsia18s_map_io,
> + .init_irq = init_irq,
> + .init_machine = gsia18s_board_init,
> +MACHINE_END
Best Regards,
J.
next prev parent reply other threads:[~2010-12-12 0:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 17:00 [PATCH v4] mach-at91: Support for gsia18s board added Igor Plyatov
2010-12-12 0:50 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2010-12-12 6:37 ` Igor Plyatov
2010-12-12 14:07 ` Jean-Christophe PLAGNIOL-VILLARD
2010-12-12 14:22 ` Russell King - ARM Linux
2010-12-12 19:52 ` Igor Plyatov
2010-12-12 23:39 ` Russell King - ARM Linux
2010-12-13 6:26 ` Igor Plyatov
2010-12-13 7:15 ` Igor Plyatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101212005048.GH19897@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=christian.glindkamp@taskit.de \
--cc=costa.antonior@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@maxim.org.za \
--cc=nicolas.ferre@atmel.com \
--cc=pgsellmann@portner-elektronik.at \
--cc=plyatov@gmail.com \
--cc=ryan@bluewatersys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox