From: Dan Carpenter <error27@gmail.com>
To: Brian Rogers <brian@xyzw.org>
Cc: Jeff Mahoney <jeffm@suse.com>,
balbir@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
Guillaume Chazarain <guichaz@gmail.com>,
akpm@linux-foundation.org
Subject: Re: delayacct: alignment changes break iotop
Date: Tue, 14 Dec 2010 00:22:53 +0300 [thread overview]
Message-ID: <20101213212253.GI1620@bicker> (raw)
In-Reply-To: <4D068869.7040305@xyzw.org>
Yeah, but the rule is that we don't break userspace... :/
Fixing the bug in iotop was always going to be the easy part. It's
great that they've applied a fix to git repo but it still takes a while
to get the fix out to users so they don't notice a problem.
I think we're going to need to put an ifdef IA64 then size is 8 else
size is 4. I just started this thread because I was hoping someone
had a different ifdef to use, like maybe there are other arches which
care about the alignment and maybe there is a way to test for it.
regards,
dan carpenter
next prev parent reply other threads:[~2010-12-13 21:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 11:37 delayacct: alignment changes break iotop Dan Carpenter
2010-12-13 12:57 ` Balbir Singh
2010-12-13 13:10 ` Dan Carpenter
2010-12-13 15:20 ` Jeff Mahoney
2010-12-13 20:56 ` Brian Rogers
2010-12-13 21:22 ` Dan Carpenter [this message]
2010-12-14 7:02 ` [patch] delayacct: fix iotop on x86_64 Dan Carpenter
2010-12-14 8:02 ` Balbir Singh
2010-12-14 8:16 ` Dan Carpenter
2010-12-14 20:16 ` Andrew Morton
2010-12-14 20:21 ` Jeff Mahoney
2010-12-15 7:10 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213212253.GI1620@bicker \
--to=error27@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=brian@xyzw.org \
--cc=guichaz@gmail.com \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox