From: Dan Carpenter <error27@gmail.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Brian Rogers <brian@xyzw.org>, Jeff Mahoney <jeffm@suse.com>,
linux-kernel@vger.kernel.org,
Guillaume Chazarain <guichaz@gmail.com>,
akpm@linux-foundation.org
Subject: Re: [patch] delayacct: fix iotop on x86_64
Date: Tue, 14 Dec 2010 11:16:20 +0300 [thread overview]
Message-ID: <20101214081620.GK1620@bicker> (raw)
In-Reply-To: <20101214080239.GC14178@balbir.in.ibm.com>
On Tue, Dec 14, 2010 at 01:32:39PM +0530, Balbir Singh wrote:
> I would rather abstract this better and I'd be apprehensive about the
> fix if iotop was at fault to begin with, I would rather fix iotop.
> IOW, are we fixing what iotop got wrong? Isn't it easier to backport
> the correct behaviour in iotop. I understand we broke the ABI, but
> user space can still live.
>
The iotop people are definitely at fault and we should throw salmon at
the developers next time when we see them at a conference. But in the
end, it's not really a matter of assigning blame to things. It's just
annoying for users if the program stops working and you have to google
to figure out why the new kernel it broke iotop.
It's simple enough to paper over the bug for now, then fix it properly
in a couple years when everyone has upgraded their user space.
regards,
dan carpenter
next prev parent reply other threads:[~2010-12-14 8:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 11:37 delayacct: alignment changes break iotop Dan Carpenter
2010-12-13 12:57 ` Balbir Singh
2010-12-13 13:10 ` Dan Carpenter
2010-12-13 15:20 ` Jeff Mahoney
2010-12-13 20:56 ` Brian Rogers
2010-12-13 21:22 ` Dan Carpenter
2010-12-14 7:02 ` [patch] delayacct: fix iotop on x86_64 Dan Carpenter
2010-12-14 8:02 ` Balbir Singh
2010-12-14 8:16 ` Dan Carpenter [this message]
2010-12-14 20:16 ` Andrew Morton
2010-12-14 20:21 ` Jeff Mahoney
2010-12-15 7:10 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214081620.GK1620@bicker \
--to=error27@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=brian@xyzw.org \
--cc=guichaz@gmail.com \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox