Re: [PATCH 04 of 66] define MADV_HUGEPAGE

Mel Gorman
2010-11-18T11:44:21Z

On just the subject, I've been hassled before to add information to the
subject on what is being affected. In this case, it would be just mm:
because you are not affecting any subsystem but others might be

mm: migration: something something

On a practical point of view, it means if you sort mmotm's series file,
you can get an approximate breakdown of how many patches affect each
subsystem. No idea if it's required or not but don't be surprised if
someone complains :)

On Wed, Nov 03, 2010 at 04:27:39PM +0100, Andrea Arcangeli wrote:
> From: Andrea Arcangeli <aarcange@redhat.com>
>
> Define MADV_HUGEPAGE.
>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> Acked-by: Rik van Riel <riel@redhat.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Otherwise;

Acked-by: Mel Gorman <mel@csn.ul.ie>

> ---
>
> diff --git a/arch/alpha/include/asm/mman.h b/arch/alpha/include/asm/mman.h
> --- a/arch/alpha/include/asm/mman.h
> +++ b/arch/alpha/include/asm/mman.h
> @@ -53,6 +53,8 @@
> #define MADV_MERGEABLE 12 /* KSM may merge identical pages */
> #define MADV_UNMERGEABLE 13 /* KSM may not merge identical pages */
>
> +#define MADV_HUGEPAGE 14 /* Worth backing with hugepages */
> +
> /* compatibility flags */
> #define MAP_FILE 0
>
> diff --git a/arch/mips/include/asm/mman.h b/arch/mips/include/asm/mman.h
> --- a/arch/mips/include/asm/mman.h
> +++ b/arch/mips/include/asm/mman.h
> @@ -77,6 +77,8 @@
> #define MADV_UNMERGEABLE 13 /* KSM may not merge identical pages */
> #define MADV_HWPOISON 100 /* poison a page for testing */
>
> +#define MADV_HUGEPAGE 14 /* Worth backing with hugepages */
> +
> /* compatibility flags */
> #define MAP_FILE 0
>
> diff --git a/arch/parisc/include/asm/mman.h b/arch/parisc/include/asm/mman.h
> --- a/arch/parisc/include/asm/mman.h
> +++ b/arch/parisc/include/asm/mman.h
> @@ -59,6 +59,8 @@
> #define MADV_MERGEABLE 65 /* KSM may merge identical pages */
> #define MADV_UNMERGEABLE 66 /* KSM may not merge identical pages */
>
> +#define MADV_HUGEPAGE 67 /* Worth backing with hugepages */
> +
> /* compatibility flags */
> #define MAP_FILE 0
> #define MAP_VARIABLE 0
> diff --git a/arch/xtensa/include/asm/mman.h b/arch/xtensa/include/asm/mman.h
> --- a/arch/xtensa/include/asm/mman.h
> +++ b/arch/xtensa/include/asm/mman.h
> @@ -83,6 +83,8 @@
> #define MADV_MERGEABLE 12 /* KSM may merge identical pages */
> #define MADV_UNMERGEABLE 13 /* KSM may not merge identical pages */
>
> +#define MADV_HUGEPAGE 14 /* Worth backing with hugepages */
> +
> /* compatibility flags */
> #define MAP_FILE 0
>
> diff --git a/include/asm-generic/mman-common.h b/include/asm-generic/mman-common.h
> --- a/include/asm-generic/mman-common.h
> +++ b/include/asm-generic/mman-common.h
> @@ -45,6 +45,8 @@
> #define MADV_MERGEABLE 12 /* KSM may merge identical pages */
> #define MADV_UNMERGEABLE 13 /* KSM may not merge identical pages */
>
> +#define MADV_HUGEPAGE 14 /* Worth backing with hugepages */
> +
> /* compatibility flags */
> #define MAP_FILE 0
>
>

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab