Re: [PATCH 53 of 66] add numa awareness to hugepage allocations

Andrea Arcangeli
2010-11-29T16:13:36Z

On Mon, Nov 29, 2010 at 02:38:01PM +0900, Daisuke Nishimura wrote:
> I think this should be:
>
> if (unlikely(mem_cgroup_newpage_charge(new_page, mm, GFP_KERNEL))) {
> #ifdef CONFIG_NUMA
> put_page(new_page);
> #endif
> goto out;
> }

Hmm no, the change you suggest would generate memory corruption with
use after free.