From: Ben Dooks <ben-i2c@fluff.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Jean Delvare <khali@linux-fr.org>,
lkml <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] GPIO_SCH and I2C_SCH: select MFD_SUPPORT to eliminate kconfig warnings
Date: Wed, 15 Dec 2010 21:21:04 +0000 [thread overview]
Message-ID: <20101215212104.GA20097@trinity.fluff.org> (raw)
In-Reply-To: <4D0920DD.3080306@oracle.com>
On Wed, Dec 15, 2010 at 12:11:09PM -0800, Randy Dunlap wrote:
> On 12/15/10 01:15, Jean Delvare wrote:
> > Hi Randy,
> >
> > On Tue, 14 Dec 2010 16:26:56 -0800, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> I2C_ISCH and GPIO_SCH need to select MFD_SUPPORT so that the
> >> dependency tree hierarchy is satisfied. This eliminates the
> >> kconfig warning:
> >>
> >> warning: (I2C_ISCH && I2C && PCI || GPIO_SCH && GPIOLIB && PCI) selects LPC_SCH which has unmet direct dependencies (MFD_SUPPORT && PCI)
> >>
Hmm, it seems that MFD_SUPPORT enables MFD_CORE, and as such, I don't
think MFD_CORE can be selected without the MFD_SUPPORT.
My view would be to add MFD_NEEDED, or NEEDS_MFD which would force
the MFD_SUPPORT and MFD_CORE on in one go.
--
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
prev parent reply other threads:[~2010-12-15 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 0:26 [PATCH] GPIO_SCH and I2C_SCH: select MFD_SUPPORT to eliminate kconfig warnings Randy Dunlap
2010-12-15 9:15 ` Jean Delvare
2010-12-15 20:11 ` Randy Dunlap
2010-12-15 21:21 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215212104.GA20097@trinity.fluff.org \
--to=ben-i2c@fluff.org \
--cc=akpm@linux-foundation.org \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox