Re: [PATCH 7/9] TILER-DMM: Main TILER driver implementation

David Sin
2010-12-13T17:20:52Z

On Mon, Dec 06, 2010 at 03:21:59PM -0800, Tony Lindgren wrote:
> Hi,
>
> * David Sin <davidsin@ti.com> [101206 14:09]:
> > From: Lajos Molnar <molnar@ti.com>
> >
> > This patch contains the TILER driver and implementation of the TILER
> > block manipulation and mapping functions.
> >
> > It also contains the makefile and config file for the TILER driver.
>
> ...
> > +config TILER_GRANULARITY
> > + int "Allocation granularity"
> > + range 1 4096
> > + default 128
> ...
> > +config TILER_ALIGNMENT
> > + int "Allocation alignment"
> > + range 1 4096
> > + default 4096
> ...
> > +config TILER_CACHE_LIMIT
> > + int "Memory limit to cache free pages in MBytes"
> > + range 0 128
> > + default 40
> ...
>
> Do you really need these Kconfig options? To me it seems you
> should pass these in platform_data.
>
> Regards,
>
> Tony
Hi Tony,
No -- we don't really need these here, but we thought that
it would be an easy way for the user to set them -- esp the
CACHE_LIMIT. We can actually remove themi, since it's not
going to change very often, and add it to plat data later.
I'll revise the patch. BTW, Are you going to be the one to
merge this code?

Regards,
--
David Sin