From: Alexey Dobriyan <adobriyan@gmail.com>
To: Dave Jones <davej@redhat.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: warn if registering world writeable files
Date: Fri, 17 Dec 2010 00:04:58 +0200 [thread overview]
Message-ID: <20101216220458.GA8103@core2.telecom.by> (raw)
In-Reply-To: <20101216212609.GA9352@redhat.com>
On Thu, Dec 16, 2010 at 04:26:10PM -0500, Dave Jones wrote:
> On Thu, Dec 16, 2010 at 10:32:17PM +0200, Alexey Dobriyan wrote:
> > + WARN_ON(S_ISREG(mode) && (mode & S_IWOTH));
> > ent->mode = mode;
> > ent->nlink = nlink;
> > atomic_set(&ent->count, 1);
>
> Not sure about this. For the reason I mentioned in the checkpatch diff
> that this is "usually" a problem. There may be some use cases where
> it may actually be ok.
>
> (I'm having a hard time thinking up a justification though tbh)
Me too.
If it's for quick debugging, one can reassign ->mode after registering and
escape the warning.
prev parent reply other threads:[~2010-12-16 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 20:32 [PATCH] proc: warn if registering world writeable files Alexey Dobriyan
2010-12-16 21:26 ` Dave Jones
2010-12-16 22:04 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216220458.GA8103@core2.telecom.by \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox