From: Chris Ball <cjb@laptop.org>
To: Philip Rakity <prakity@marvell.com>
Cc: Takashi Iwai <tiwai@suse.de>, Aries Lee <arieslee@jmicron.com>,
zhangfei gao <zhangfei.gao@gmail.com>,
Qiming Wu <wuqm@marvell.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: Test bus-width for old MMC devices (v2)
Date: Fri, 17 Dec 2010 03:43:42 +0000 [thread overview]
Message-ID: <20101217034342.GA19673@void.printf.net> (raw)
In-Reply-To: <50D31EC8-BD9E-4920-8CEB-2AD10DF9C5C5@marvell.com>
Hi Philip,
On Thu, Dec 16, 2010 at 06:33:49PM -0800, Philip Rakity wrote:
> It is not possible for bus_width to be not initialized. This would imply ARRAY_SIZE(bus_widths) is 1. Certainly not true.
Right, I agree. We should fix the warning anyway.
> We could just initialize by changing
> + unsigned idx, bus_width;
> to
> + unsigned idx, bus_width = 0;
Okay, I've pushed to mmc-next with that change.
> I wonder what compiler are you using so we can avoid this issue in future.
Ah, good point -- I was building with a gcc 4.1.2 ARM cross-compiler,
and using a gcc 4.5.1 cross-build instead avoids the warning.
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-12-17 3:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 7:14 [PATCH] mmc: Test bus-width for old MMC devices (v2) Takashi Iwai
2010-12-15 13:17 ` [PATCH] mmc: Enable bus-width tests on SDHCI host Takashi Iwai
2010-12-15 19:40 ` Takashi Iwai
2010-12-16 16:54 ` [PATCH] mmc/sdhci: Enable bus-width test for JMicron controllers Takashi Iwai
2010-12-17 3:58 ` Chris Ball
2010-12-16 23:40 ` [PATCH] mmc: Test bus-width for old MMC devices (v2) Chris Ball
2010-12-17 2:33 ` Philip Rakity
2010-12-17 3:43 ` Chris Ball [this message]
2010-12-17 8:11 ` Takashi Iwai
2010-12-21 10:59 ` zhangfei gao
2010-12-21 16:36 ` Philip Rakity
2010-12-21 19:35 ` Philip Rakity
2010-12-22 3:56 ` zhangfei gao
2010-12-22 8:59 ` Takashi Iwai
2010-12-28 8:27 ` zhangfei gao
2011-01-02 19:52 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217034342.GA19673@void.printf.net \
--to=cjb@laptop.org \
--cc=arieslee@jmicron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
--cc=tiwai@suse.de \
--cc=wuqm@marvell.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox