Re: [PATCH] mmc: Enable bus-width tests on SDHCI host

Takashi Iwai
2010-12-15T19:40:56Z

At Wed, 15 Dec 2010 14:17:27 +0100,
Takashi Iwai wrote:
>
> Let's enable the new bus-width tests on SDHCI hosts unless 1-bit data
> is set forcibly.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Please drop this patch.

After a short discussion with Philip, we concluded that it's safer to
enable in individual platform side.

I'll send a patch for enabling the feature for JMicron chips later again.

thanks,

Takashi

> ---
>
> This is a patch to be applied after
> "mmc: Test bus-width for old MMC devices (v2)"
>
>
> drivers/mmc/host/sdhci.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 0502738..51f5209 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1888,8 +1888,10 @@ int sdhci_add_host(struct sdhci_host *host)
> * their platform code before calling sdhci_add_host(), and we
> * won't assume 8-bit width for hosts without that CAP.
> */
> - if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA))
> + if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA)) {
> mmc->caps |= MMC_CAP_4_BIT_DATA;
> + mmc->caps |= MMC_CAP_BUS_WIDTH_TEST;
> + }
>
> if (caps & SDHCI_CAN_DO_HISPD)
> mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
> --
> 1.7.3.1
>