From: Greg KH <greg@kroah.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
LSM <linux-security-module@vger.kernel.org>,
James Morris <jmorris@namei.org>,
Kees Cook <kees.cook@canonical.com>,
containers@lists.linux-foundation.org,
kernel list <linux-kernel@vger.kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Michael Kerrisk <michael.kerrisk@gmail.com>
Subject: Re: [RFC 1/5] user namespaces: Add a user_namespace as creator/owner of uts_namespace
Date: Fri, 17 Dec 2010 15:15:27 -0800 [thread overview]
Message-ID: <20101217231527.GA21227@kroah.com> (raw)
In-Reply-To: <m1ipysm8us.fsf@fess.ebiederm.org>
On Fri, Dec 17, 2010 at 12:40:11PM -0800, Eric W. Biederman wrote:
> Greg KH <greg@kroah.com> writes:
>
> >> There are also major benefits to have the version of something that is
> >> never freed never going away, because it means you can just reference it
> >> in code. So while I would be happy to say this is special don't use a
> >> kref and roll the reference counting logic by hand, we aren't
> >> dynamically allocating init_uts_ns any time soon.
> >
> > Why have a reference count at all if it's not needed or used here?
>
> We have to reference count every other uts namespace.
Ok, that makes sense, then also please dynamically create this one, do
not create a static kref.
thanks,
greg k-h
next prev parent reply other threads:[~2010-12-17 23:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 15:22 [RFC 0/5] user namespaces: start clamping down Serge E. Hallyn
2010-12-17 15:24 ` [RFC 1/5] user namespaces: Add a user_namespace as creator/owner of uts_namespace Serge E. Hallyn
2010-12-17 15:25 ` [RFC 2/5] user namespaces: make capabilities relative to the user namespace Serge E. Hallyn
2010-12-17 15:26 ` [RFC 3/5] user namespaces: allow sethostname in a container Serge E. Hallyn
2010-12-17 15:26 ` [RFC 4/5] user namespaces: allow killing tasks in your own or child userns Serge E. Hallyn
2010-12-17 15:27 ` [RFC 5/5] user namespaces: Allow ptrace from non-init user namespaces Serge E. Hallyn
2010-12-17 19:45 ` Eric W. Biederman
2010-12-17 20:04 ` Serge Hallyn
2011-01-01 4:47 ` Serge E. Hallyn
2010-12-17 19:31 ` [RFC 4/5] user namespaces: allow killing tasks in your own or child userns Eric W. Biederman
2010-12-17 20:09 ` Serge E. Hallyn
2010-12-17 20:17 ` Eric W. Biederman
2010-12-17 20:22 ` Serge E. Hallyn
2011-01-01 4:45 ` Serge E. Hallyn
2011-01-01 23:10 ` Eric W. Biederman
2011-01-02 14:39 ` Serge E. Hallyn
2010-12-17 15:56 ` [RFC 1/5] user namespaces: Add a user_namespace as creator/owner of uts_namespace Alexey Dobriyan
2010-12-17 16:00 ` Alexey Dobriyan
2010-12-17 16:17 ` Serge Hallyn
2010-12-17 16:12 ` Serge Hallyn
2010-12-17 17:31 ` Greg KH
2010-12-17 19:26 ` Eric W. Biederman
2010-12-17 19:58 ` Greg KH
2010-12-17 20:40 ` Eric W. Biederman
2010-12-17 23:15 ` Greg KH [this message]
2010-12-18 6:32 ` Eric W. Biederman
2010-12-18 17:56 ` Greg KH
2010-12-17 19:46 ` Serge Hallyn
2010-12-17 19:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217231527.GA21227@kroah.com \
--to=greg@kroah.com \
--cc=adobriyan@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jmorris@namei.org \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=michael.kerrisk@gmail.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox