Re: [PATCHv6 15/16] pps: add parallel port PPS client

Andrew Morton
2010-12-18T01:13:44Z

On Sat, 18 Dec 2010 03:50:54 +0300
Alexander Gordeev <lasaine@lvk.cs.msu.su> wrote:

> __ Fri, 17 Dec 2010 16:17:56 -0800
> Andrew Morton <akpm@linux-foundation.org> __________:
>
> > On Fri, 17 Dec 2010 22:54:39 +0300
> > Alexander Gordeev <lasaine@lvk.cs.msu.su> wrote:
> >
> > > Add parallel port PPS client. It uses a standard method for capturing
> > > timestamps for assert edge transitions: getting a timestamp soon after
> > > an interrupt has happened. This is not a very precise source of time
> > > information due to interrupt handling delays. However, timestamps for
> > > clear edge transitions are much more precise because the interrupt
> > > handler continuously polls hardware port until the transition is done.
> > > Hardware port operations require only about 1us so the maximum error
> > > should not exceed this value. This was my primary goal when developing
> > > this client.
> > > Clear edge capture could be disabled using clear_wait parameter.
> > >
> > > ...
> > >
> > > +/* parport interrupt handler */
> > > +static void parport_irq(void *handle)
> > > +{
> > > + struct pps_event_time ts_assert, ts_clear;
> > > + struct pps_client_pp *dev = handle;
> > > + struct parport *port = dev->pardev->port;
> > > + unsigned int i;
> > > + unsigned long flags;
> > > +
> > > + /* first of all we get the time stamp... */
> > > + pps_get_ts(&ts_assert);
> > > +
> > > + if (dev->cw == 0)
> > > + /* clear edge capture disabled */
> > > + goto out_assert;
> > > +
> > > + /* try capture the clear edge */
> > > + local_irq_save(flags);
> > > + /* check the signal (no signal means the pulse is lost this time) */
> > > + if (!signal_is_set(port)) {
> > > + local_irq_restore(flags);
> > > + dev_err(dev->pps->dev, "lost the signal\n");
> > > + goto out_assert;
> > > + }
> > > +
> > > + /* poll the port until the signal is unset */
> > > + for (i = dev->cw; i; i--)
> > > + if (!signal_is_set(port)) {
> > > + pps_get_ts(&ts_clear);
> > > + local_irq_restore(flags);
> > > + dev->cw_err = 0;
> > > + goto out_both;
> > > + }
> > > + local_irq_restore(flags);
> >
> > Why is this function paying around with local_irq_save()? It's unusual
> > and looks buggy because local_irq_save() doesn't stop other CPUs from
> > taking an interrupt and coming in and playing with the "protected" data.
>
> The idea is to prevent other interrupts on the same processor to
> introduce uncontrolled time lags here. Reading from IO port is known to
> take approximately 1us while other interrupt handlers can probably take
> much more. So I poll the port with locally disabled interrupts to
> ensure that the maximum lag here is 1us. All my experiments show that
> it is in fact very precise this way given that input signal is precise.

Please send along a patch which explains all this to future readers?

> Hmm. Do you want me to rewrite the parport subsystem?

yep! And page reclaim, writeback and readahead, please.