From: "Henrik Rydberg" <rydberg@euromail.se>
To: Chris Bagwell <chris@cnpbagwell.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
Chase Douglas <chase.douglas@canonical.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/4] Input: synaptics - add multitouch packet support
Date: Sat, 18 Dec 2010 18:54:08 +0100 [thread overview]
Message-ID: <20101218175408.GA1709@polaris.bitmath.org> (raw)
In-Reply-To: <AANLkTimrNrfTXGh675_8zhOg_+9+NKgOmzJq9rafyh+6@mail.gmail.com>
Hi Chris,
Thanks for you comments.
> > While in MT mode and two or three fingers are touching, two sets of
> > data are sent. The first is a new format buffer with lower resolution
> > reporting of stationary finger and the second is standard data format
> > reporting movement.
>
> We should probably update this comment and remove parts that mention
> stationary and movement. It appears to be doing finger tracking and
> first packet is always first touch... except we are getting reports
> that clickpads/integrated button pads may not be consistently like
> this.
Yes, good point. Will update.
> This tracking is partly why type B protocol is being used in later patches.
The original thought was that the two points corresponded well to the
two fingers, only sometimes in the wrong order. The solution then was
to use the tracking module to order them appropriately. As it turned
out that the fingers are not followed that well after all, the whole
idea fell flat, so we resorted to only sending the bounding rectangle,
which requires no tracking.
All in all, this patchset contains enough information to resolve
jumping and clickpad issues in user space, at the same time as it
keeps compatibility with mousedev and older hardware. We know there
are still issues, but I see no real reason to postpone these changes
any further.
Thanks,
Henrik
next prev parent reply other threads:[~2010-12-18 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 14:52 [PATCH 0/4] Input: synaptics - add semi-mt support Henrik Rydberg
2010-12-18 14:52 ` [PATCH 1/4] Input: synaptics - add multitouch packet support Henrik Rydberg
2010-12-18 16:55 ` Chris Bagwell
2010-12-18 16:56 ` Chris Bagwell
2010-12-18 17:06 ` Henrik Rydberg
2010-12-18 17:54 ` Henrik Rydberg [this message]
2010-12-18 20:44 ` Chris Bagwell
2010-12-21 16:45 ` Chase Douglas
2010-12-19 8:16 ` Dmitry Torokhov
2010-12-19 9:36 ` Henrik Rydberg
2010-12-18 14:52 ` [PATCH 2/4] Input: synaptics - ignore bogus mt packet Henrik Rydberg
2010-12-18 17:05 ` Chris Bagwell
2010-12-18 14:53 ` [PATCH 3/4] Input: synaptics - report clickpad property Henrik Rydberg
2010-12-18 14:53 ` [PATCH 4/4] Input: synaptics - emit multitouch data Henrik Rydberg
2010-12-18 17:11 ` Chris Bagwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218175408.GA1709@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=chase.douglas@canonical.com \
--cc=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox