public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Matthew Wilcox <willy@linux.intel.com>,
	Jens Axboe <jaxboe@fusionio.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org,
	Shane Michael Matthews <shane.matthews@intel.com>,
	Jeff Moyer <jmoyer@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	"Luck, Tony" <tony.luck@intel.com>,
	Florian Mickler <florian@mickler.org>
Subject: Re: [PATCH] Add readpages support for block devices
Date: Sun, 19 Dec 2010 11:35:52 +0800	[thread overview]
Message-ID: <20101219033552.GA9247@localhost> (raw)
In-Reply-To: <20101218092049.GA32442@lst.de>

On Sat, Dec 18, 2010 at 10:20:49AM +0100, Christoph Hellwig wrote:
> We already used to have this and Jens reverted it in commit
> 172124e220f1854acc99ee394671781b8b5e2120.  I can't find a better
> explanation than his rather brief commit message, but he might not more.

The discussion goes here

http://www.gossamer-threads.com/lists/linux/kernel/1085325?do=post_view_threaded#1085325

The problem happens on ext3 fs, non-4k aligned partition and 64K page
size. Jeff also find it hurts dump performance. Then it's reverted
since no one seems to have the time to dig further.

Thanks,
Fengguang

      reply	other threads:[~2010-12-19  3:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18  0:27 [PATCH] Add readpages support for block devices Matthew Wilcox
2010-12-18  9:20 ` Christoph Hellwig
2010-12-19  3:35   ` Wu Fengguang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101219033552.GA9247@localhost \
    --to=fengguang.wu@intel.com \
    --cc=axboe@kernel.dk \
    --cc=florian@mickler.org \
    --cc=hch@lst.de \
    --cc=jaxboe@fusionio.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shane.matthews@intel.com \
    --cc=tony.luck@intel.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox