From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Sundar Iyer <sundar.iyer@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: linux-next: manual merge of the mfd tree with the ux500-core tree
Date: Mon, 20 Dec 2010 12:12:16 +0000 [thread overview]
Message-ID: <20101220121215.GC26706@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20101220042344.GB10050@linux-sh.org>
On Mon, Dec 20, 2010 at 01:23:44PM +0900, Paul Mundt wrote:
> On Mon, Dec 20, 2010 at 03:21:48PM +1100, Stephen Rothwell wrote:
> > -static void tc3589x_irq_dummy(unsigned int irq)
> > +static void tc3589x_irq_dummy(struct irq_data *data)
> > {
> > /* No mask/unmask at this level */
> > }
> >
> > static struct irq_chip tc3589x_irq_chip = {
> > - .name = "tc3589x",
> > - .mask = tc3589x_irq_dummy,
> > - .unmask = tc3589x_irq_dummy,
> > + .name = "tc3589x",
> > + .irq_mask = tc3589x_irq_dummy,
> > + .irq_unmask = tc3589x_irq_dummy,
> > };
> > static int tc3589x_irq_init(struct tc3589x *tc3589x)
> Is there some reason you don't just kill this off and use dummy_irq_chip?
Mainly that I didn't take the time to read through the code and figure
out if it was doing anything interesting with the struct elsewhere
which meant this was actually sensible (one of the other drivers was
doing something surprising).
prev parent reply other threads:[~2010-12-20 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 4:21 linux-next: manual merge of the mfd tree with the ux500-core tree Stephen Rothwell
2010-12-20 4:23 ` Paul Mundt
2010-12-20 12:05 ` Samuel Ortiz
2010-12-20 12:12 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220121215.GC26706@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sfr@canb.auug.org.au \
--cc=sundar.iyer@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox