From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Mikael Ström" <mikael@sesamiq.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Julien BLACHE <jb@jblache.org>, Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <guenter.roeck@ericsson.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices
Date: Mon, 20 Dec 2010 14:00:32 +0000 [thread overview]
Message-ID: <20101220140032.GA23257@srcf.ucam.org> (raw)
In-Reply-To: <1292852674.2118.10.camel@mike-laptop>
On Mon, Dec 20, 2010 at 09:44:34PM +0800, Mikael Ström wrote:
> Hi,
>
> I know nothing about the background to the mail below, but if it's of
> any help, macfanctld uses the following hardwired paths,
>
> reading:
>
> /sys/devices/platform/applesmc.768/temp<n>_input
>
> and writing:
>
> /sys/devices/platform/applesmc.768/fan1_min
> /sys/devices/platform/applesmc.768/fan2_min
> /sys/devices/platform/applesmc.768/fan1_manual
> /sys/devices/platform/applesmc.768/fan2_manual
>
> If any of those are to be broken, please advice in advance so i can
> update the source before you break it, avoiding that the users fry their
> MacBooks.
Yes, it's very broken. Walk /sys/class/hwmon and look for an entry with
an appropriate name, don't hardcode device paths. But given the
breakage, it might be easier to just keep the platform device for now.
I'll redo the patch with that in mind.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-12-20 14:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 15:33 [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-16 15:33 ` [PATCH 2/2] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
2010-12-16 16:48 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-16 17:00 ` Matthew Garrett
2010-12-16 17:00 ` [lm-sensors] " Guenter Roeck
2010-12-17 21:57 ` Matthew Garrett
2010-12-17 21:58 ` Matthew Garrett
2010-12-17 22:16 ` Guenter Roeck
2010-12-17 22:22 ` Matthew Garrett
2010-12-17 22:24 ` [PATCH 1/2 V3] " Matthew Garrett
2010-12-18 4:23 ` Guenter Roeck
2010-12-18 9:07 ` Henrik Rydberg
2010-12-18 14:40 ` Matthew Garrett
2010-12-18 15:31 ` Henrik Rydberg
2010-12-18 9:37 ` Henrik Rydberg
2010-12-18 10:09 ` [lm-sensors] " Jean Delvare
2010-12-18 10:31 ` Henrik Rydberg
2010-12-18 11:29 ` Julien BLACHE
2010-12-18 11:57 ` Henrik Rydberg
2010-12-20 13:44 ` Mikael Ström
2010-12-20 13:57 ` Jean Delvare
2010-12-20 14:23 ` Henrik Rydberg
2010-12-20 14:28 ` Matthew Garrett
2010-12-20 15:06 ` Henrik Rydberg
2010-12-20 15:12 ` Matthew Garrett
2010-12-20 15:37 ` Henrik Rydberg
2010-12-20 14:00 ` Matthew Garrett [this message]
2010-12-21 6:04 ` Mikael Ström
2010-12-21 11:09 ` Julien BLACHE
2010-12-18 14:43 ` Matthew Garrett
2010-12-18 15:30 ` Henrik Rydberg
2010-12-18 15:39 ` Matthew Garrett
2010-12-17 22:24 ` [PATCH 2/2 V3] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
2010-12-17 21:58 ` [PATCH 2/2] " Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220140032.GA23257@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=guenter.roeck@ericsson.com \
--cc=jb@jblache.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mikael@sesamiq.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox