public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
	Roland McGrath <roland@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH][RFC] Always unlock 'tasklist_lock' in kernel/exit.c::do_wait()
Date: Mon, 20 Dec 2010 21:54:32 -0800	[thread overview]
Message-ID: <20101220215432.af5798d5.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1012202324540.23785@swampdragon.chaosbits.net>

On Mon, 20 Dec 2010 23:30:38 +0100 (CET) Jesper Juhl <jj@chaosbits.net> wrote:

> The Coverity checker spotted this. I think it has a point, but I'm not 
> intimate with this code so there could be somethingI'm missing.
> 
> It seems that kernel/exit.c::do_wait() does not always release 
> 'tasklist_lock'.

do_wait_thread() and ptrace_do_wait() will have released tasklist_lock
if they returned non-zero.


  reply	other threads:[~2010-12-21  5:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20 22:30 [PATCH][RFC] Always unlock 'tasklist_lock' in kernel/exit.c::do_wait() Jesper Juhl
2010-12-21  5:54 ` Andrew Morton [this message]
2010-12-21 10:30 ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101220215432.af5798d5.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox