From: Anton Vorontsov <cbouatmailru@gmail.com>
To: rklein <rklein@nvidia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Chew <AChew@nvidia.com>, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 1/1] power: bq20z75: Update return value of CURRENT NOW
Date: Wed, 22 Dec 2010 02:22:30 +0300 [thread overview]
Message-ID: <20101221232230.GA5417@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1292892862.12618.1.camel@rklein-linux2>
On Mon, Dec 20, 2010 at 04:54:22PM -0800, rklein wrote:
> On Tue, 2010-12-14 at 19:04 -0800, Olof Johansson wrote:
> > On Tue, Dec 14, 2010 at 05:01:25PM -0800, rklein wrote:
> > > The BQ20Z75 will return a negative value for current if the battery is
> > > discharging and a positive value if charging. This should always be
> > > exported
> > > as a positive number.
> > >
> > > Signed-off-by: Rhyland Klein <rklein@nvidia.com>
> >
> > Reviewed-by: Olof Johansson <olof@lixom.net>
> >
> > -Olof
>
> Anton, is this patch ok to get put in?
I'm not sure. Probably not. Why would you think that the current
should always be positive? For ds2760 it isn't, for example.
If some driver assumes always positive current, I think it should
be fixed instead.
If the battery is discharging, let it be negative. That's what
happens on wires anyway. :-)
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2010-12-21 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 1:01 [PATCH 1/1] power: bq20z75: Update return value of CURRENT NOW rklein
2010-12-15 3:04 ` Olof Johansson
[not found] ` <1292892862.12618.1.camel@rklein-linux2>
2010-12-21 23:22 ` Anton Vorontsov [this message]
2010-12-21 23:41 ` rklein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101221232230.GA5417@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=AChew@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox