From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] POWER: gpio-charger: Fix potential race between irq handler and probe/remove function
Date: Wed, 22 Dec 2010 03:05:01 +0300 [thread overview]
Message-ID: <20101222000501.GB24834@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1290118119-16468-2-git-send-email-lars@metafoo.de>
On Thu, Nov 18, 2010 at 11:08:38PM +0100, Lars-Peter Clausen wrote:
> This patch fixes a potential race between the irq handler and the probe and
> remove functions.
> The irq should not be requested before the chargers power_supply has been
> registered and has to be freed before the power_supply is unregistered,
> otherwise it is possible that the irq fires while the power_supply is not
> initialized yet or has already been freed.
>
> While we are at it replace request_irq with request_any_context_irq.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to battery-2.6.git, thanks!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2010-12-22 0:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 22:08 [PATCH] POWER: gpio-charger: Check result of kzalloc Lars-Peter Clausen
2010-11-18 22:08 ` [PATCH] POWER: gpio-charger: Fix potential race between irq handler and probe/remove function Lars-Peter Clausen
2010-12-22 0:05 ` Anton Vorontsov [this message]
2010-11-18 22:08 ` [PATCH] POWER: gpio-chager: Provide default name for the power_supply Lars-Peter Clausen
2010-12-22 0:04 ` Anton Vorontsov
2010-12-22 0:03 ` [PATCH] POWER: gpio-charger: Check result of kzalloc Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222000501.GB24834@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox