From: Greg KH <gregkh@suse.de>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com
Subject: Re: [PATCH] pch_phub: add new device ML7213
Date: Tue, 21 Dec 2010 20:44:25 -0800 [thread overview]
Message-ID: <20101222044424.GC19006@suse.de> (raw)
In-Reply-To: <1292992394-3264-1-git-send-email-tomoya-linux@dsn.okisemi.com>
On Wed, Dec 22, 2010 at 01:33:14PM +0900, Tomoya MORINAGA wrote:
> @@ -688,6 +720,7 @@ static int pch_phub_resume(struct pci_dev *pdev)
>
> static struct pci_device_id pch_phub_pcidev_id[] = {
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PCH1_PHUB)},
> + {PCI_DEVICE(PCI_VENDOR_ID_ROHM, PCI_DEVICE_ID_ROHM_ML7213_PHUB)},
Put the device type here in the device table, so you don't have to check
for it again in the probe function. That way you can save some code and
keep things simpler and more obvious in the future when adding new
device ids, that you also have to pick the type for it.
thanks,
greg k-h
next prev parent reply other threads:[~2010-12-22 4:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 4:33 [PATCH] pch_phub: add new device ML7213 Tomoya MORINAGA
2010-12-22 4:43 ` Greg KH
2010-12-22 4:44 ` Greg KH [this message]
2011-01-12 1:59 ` Tomoya MORINAGA
2011-01-12 3:04 ` Greg KH
2011-01-28 8:53 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222044424.GC19006@suse.de \
--to=gregkh@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox