public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org,
	Samuel Ortiz <sameo@linux.intel.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Lukasz Majewski <l.majewski@samsung.com>,
	myungjoo.ham@gmail.com
Subject: Re: [PATCH v2 5/6] MFD MAX8998/LP3974: Charger Support
Date: Wed, 22 Dec 2010 13:33:59 +0000	[thread overview]
Message-ID: <20101222133359.GF26306@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1292998991-26968-6-git-send-email-myungjoo.ham@samsung.com>

On Wed, Dec 22, 2010 at 03:23:10PM +0900, MyungJoo Ham wrote:
> With the new regulator, "CHARGER", users can control charging
> current and turn on and off the charger. Note that the charger
> specification of LP3974 is different from that of MAX8998.
> 
> "CHARGER_ONLINE" monitors the charger status, which can be
> different from the status "CHARGER"; e.g., users allowed the charger
> to charge, but the MAX8998 chip decided not to do so.
> 
> "BATTERY_ONLINE" monitors the battery status (the existence of the
> battery).

Normally I'd expect a battery charger to be exposed via the power supply
API - I'd at least expect to see a consumer in the power supply API
which manages the charger and given the amount of automation you usually
see in chargers integrated into PMICs (things like automatically
starting and stopping themselves) it's not entirely clear that they map
on that well to the regulator API.

  reply	other threads:[~2010-12-22 13:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-21  2:22 [PATCH] MFD MAX8998/LP3974: Add Features: hibernation, charger, and other misc MyungJoo Ham
2010-12-21 15:50 ` Mark Brown
2010-12-22  6:23   ` [PATCH v2 0/6] MFD MAX8998/LP3974 Driver Update MyungJoo Ham
2010-12-22  6:23   ` [PATCH v2 1/6] MFD MAX8998/LP3974: Support Hibernation MyungJoo Ham
2010-12-22 13:22     ` Mark Brown
2010-12-23  1:40       ` MyungJoo Ham
2010-12-22  6:23   ` [PATCH v2 2/6] MFD MAX8998/LP3974: Support LP3974 RTC MyungJoo Ham
2010-12-22 13:25     ` Mark Brown
2010-12-23  1:45       ` MyungJoo Ham
2010-12-22  6:23   ` [PATCH v2 3/6] MFD MAX8998/LP3974 Bugfix: incorrect variable name (typo) MyungJoo Ham
2010-12-22 13:27     ` Mark Brown
2010-12-23  8:23       ` MyungJoo Ham
2010-12-22  6:23   ` [PATCH v2 4/6] MFD MAX8998/LP3974 Bufgix: accessing array out of bound MyungJoo Ham
2010-12-22 13:29     ` Mark Brown
2010-12-22  6:23   ` [PATCH v2 5/6] MFD MAX8998/LP3974: Charger Support MyungJoo Ham
2010-12-22 13:33     ` Mark Brown [this message]
2010-12-23  2:10       ` MyungJoo Ham
2010-12-23  2:36         ` Mark Brown
2010-12-22  6:23   ` [PATCH v2 6/6] MFD MAX8998/LP3974: Support DVS-GPIO MyungJoo Ham
2010-12-22 13:36     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101222133359.GF26306@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=a.zummo@towertech.it \
    --cc=jy0922.shim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=l.majewski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=myungjoo.ham@gmail.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox