Re: [tip:perf/core] tracing: Only trace sched_wakeup if it actually work something up

Ingo Molnar
2010-12-22T16:12:49Z

* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 2010-12-22 at 14:19 +0100, Peter Zijlstra wrote:
> > On Wed, 2010-12-22 at 13:16 +0000, tip-bot for Steven Rostedt wrote:
> > > Commit-ID: 14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> > > Gitweb: http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> > > Author: Steven Rostedt <srostedt@redhat.com>
> > > AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500
> > > Committer: Steven Rostedt <rostedt@goodmis.org>
> > > CommitDate: Fri, 3 Dec 2010 10:46:59 -0500
> > >
> > > tracing: Only trace sched_wakeup if it actually work something up
> > >
> > > Currently the tracepoint sched_wakeup traces the wakeup event even
> > > if the wakeup failed to wake anything up. This is quite stupid
> > > but it happens because we did not want to add a conditional
> > > to the core kernel code that would just slow down the wakeup events.
> > >
> > > This patch changes the wakeup tracepoints to use the
> > >
> > > DEFINE_EVENT_CONDITIONAL()
> > >
> > > to test the "success" parameter and will only trace the event if
> > > the wakeup was successfull.
> > >
> > > The success field in the tracepoint is removed since it is no
> > > longer needed.
> >
> > I NAKed this, its stupid.
>
> I wouldn't call it stupid, but unnecessary, yes.
>
> Anyway, it was the last patch of the series.
>
> Ingo, can you revert this last patch?

Yeah, done.

Thanks guys,

Ingo