Re: [PATCH v2] x86, nmi_watchdog: Remove ARCH_HAS_NMI_WATCHDOG and rely on CONFIG_HARDLOCKUP_DETECTOR

[Don Zickus <dzickus@redhat.com>]

On Wed, Dec 22, 2010 at 05:24:52PM +0100, Ingo Molnar wrote:
> 
> * Don Zickus <dzickus@redhat.com> wrote:
> 
> > Tested with
> > ARCH=i386: allnoconfig, defconfig, allyesconfig, (various broken configs)
> > ARCH=x86_64: allnoconfig, defconfig, allyesconfig, (various broken configs)
> > 
> > Hopefully, after this patch I won't get any more compile broken emails. :-)
> > 
> > Signed-off-by: Don Zickus <dzickus@redhat.com>
> 
> There's still some assumptions in the oprofile code, which breaks the build with 
> your patch applied:
> 
>  arch/x86/oprofile/op_model_p4.c:394:4: error: implicit declaration of function ‘release_perfctr_nmi’
>  arch/x86/oprofile/op_model_p4.c:403:4: error: implicit declaration of function ‘release_evntsel_nmi’
>  arch/x86/oprofile/op_model_p4.c:419:3: error: implicit declaration of function ‘reserve_perfctr_nmi’
>  arch/x86/oprofile/op_model_p4.c:428:3: error: implicit declaration of function ‘reserve_evntsel_nmi’
> 
> Config attached.

Thanks.  I sent a patch to fix this.  Basically they were using
linux/nmi.h instead of asm/nmi.h.

Cheers,
Don