From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Rabin Vincent <rabin@rab.in>, Ben Dooks <ben-linux@fluff.org>,
Jean Delvare <khali@linux-fr.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-pm@lists.linux-foundation.org,
patches@opensource.wolfsonmicro.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [linux-pm] [PATCH 2/2] i2c: Factor out runtime suspend checks from PM operations
Date: Wed, 22 Dec 2010 22:08:59 +0100 [thread overview]
Message-ID: <201012222208.59577.rjw@sisk.pl> (raw)
In-Reply-To: <20101222152550.GA16099@opensource.wolfsonmicro.com>
On Wednesday, December 22, 2010, Mark Brown wrote:
> On Wed, Dec 22, 2010 at 08:40:23PM +0530, Rabin Vincent wrote:
>
> > Shouldn't you be deleting the pm_runtime_* stuff from here? There is
> > already done in pm_generic_restore() iff the callback exists and returns
> > zero.
>
> I guess; it's not clear why this is being done by the bus at all or how
> it interacts with the legacy stuff.
It is done, because when the driver's ->resume() or ->restore() brings the
device up (which should have happened if it returned 0), we need to mark
the device as "active" for runtime PM.
Since __pm_generic_resume() does that, it's not necessary to do it in the
bus type callbacks (in the "legacy" case we known that runtime PM is not
supported).
Thanks,
Rafael
next prev parent reply other threads:[~2010-12-22 21:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 14:33 [PATCH 1/2] PM: Prototype the pm_generic_ operations Mark Brown
2010-12-20 14:33 ` [PATCH 2/2] i2c: Factor out runtime suspend checks from PM operations Mark Brown
2010-12-22 15:10 ` [linux-pm] " Rabin Vincent
2010-12-22 15:25 ` Mark Brown
2010-12-22 21:08 ` Rafael J. Wysocki [this message]
2010-12-20 21:08 ` [PATCH 1/2] PM: Prototype the pm_generic_ operations Rafael J. Wysocki
2010-12-22 11:43 ` [linux-pm] " Mark Brown
2010-12-22 12:15 ` Rafael J. Wysocki
2010-12-22 12:19 ` Mark Brown
2010-12-24 14:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012222208.59577.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rabin@rab.in \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox