From: Samuel Ortiz <sameo@linux.intel.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Kyungmin Park <kyungmin.park@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Lukasz Majewski <l.majewski@samsung.com>,
myungjoo.ham@gmail.com
Subject: Re: [PATCH v3 2/4] MFD MAX8998/LP3974: Support LP3974 RTC
Date: Fri, 24 Dec 2010 12:38:06 +0100 [thread overview]
Message-ID: <20101224113805.GI27832@sortiz-mobl> (raw)
In-Reply-To: <1293094419-24221-3-git-send-email-myungjoo.ham@samsung.com>
Hi MyungJoo,
On Thu, Dec 23, 2010 at 05:53:37PM +0900, MyungJoo Ham wrote:
> The first releases of LP3974 have a large delay in RTC registers,
> which requires 2 seconds of delay after writing to a rtc register
> (recommended by National Semiconductor's engineers)
> before reading it. If the device name is "lp3974-regerr", the rtc driver
> assumes that such delays are required. If the device name is "lp3974",
> the rtc driver does not. Although we have not seen LP3974s without
> requiring such delays, we assume that such LP3974s will be released
> soon (or they have done so already) and they are supported by "lp3974".
>
> This patch adds delays with msleep when writing values to RTC registers
> if the device name is "lp3974-regerr".
As Mark pointed out, I'd prefer to add a regerr flag to the driver platform
data and decide which cell to add from there.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-12-24 11:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 8:53 [PATCH v3 0/4] MFD MAX8998/LP3974 Driver Update MyungJoo Ham
2010-12-23 8:53 ` [PATCH v3 1/4] MFD MAX8998/LP3974: Support Hibernation MyungJoo Ham
2010-12-24 11:38 ` Samuel Ortiz
2010-12-23 8:53 ` [PATCH v3 2/4] MFD MAX8998/LP3974: Support LP3974 RTC MyungJoo Ham
2010-12-24 11:38 ` Samuel Ortiz [this message]
2011-01-04 5:17 ` [PATCH v4 0/3] MFD MAX8998/LP3974 Driver Update MyungJoo Ham
2011-01-04 5:17 ` [PATCH v4 1/3] MFD MAX8998/LP3974: Support LP3974 RTC MyungJoo Ham
2011-01-04 13:40 ` Mark Brown
2011-01-11 11:22 ` Samuel Ortiz
2011-01-04 5:17 ` [PATCH v4 2/3] regulator MAX8998/LP3974: Support DVS-GPIO MyungJoo Ham
2011-01-04 7:49 ` Lukasz Majewski
2011-01-04 8:16 ` MyungJoo Ham
2011-01-04 13:44 ` Mark Brown
2011-01-11 11:22 ` Samuel Ortiz
2011-01-04 5:17 ` [PATCH v4 3/3] MFD MAX8998/LP3974: Support Charger MyungJoo Ham
2011-01-04 13:56 ` Mark Brown
2011-01-05 0:43 ` MyungJoo Ham
2011-01-14 5:22 ` [PATCH v5] " MyungJoo Ham
2011-01-18 11:37 ` Mark Brown
2010-12-23 8:53 ` [PATCH v3 3/4] regulator MAX8998/LP3974: Support DVS-GPIO MyungJoo Ham
2010-12-24 11:36 ` Samuel Ortiz
2011-01-02 13:56 ` Mark Brown
2010-12-23 8:53 ` [PATCH v3 4/4] MFD MAX8998/LP3974: Support Charger MyungJoo Ham
2010-12-24 11:37 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101224113805.GI27832@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=l.majewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=myungjoo.ham@gmail.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox