From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Ian Lartey <ian@opensource.wolfsonmicro.com>,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 3/9] ASoC: codecs: wm8523: Fix register cache incoherency
Date: Fri, 24 Dec 2010 15:59:30 +0000 [thread overview]
Message-ID: <20101224155929.GC16614@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1293198484-1902-4-git-send-email-lars@metafoo.de>
On Fri, Dec 24, 2010 at 02:47:58PM +0100, Lars-Peter Clausen wrote:
> /* Change some default settings - latch VU and enable ZC */
> - wm8523->reg_cache[WM8523_DAC_GAINR] |= WM8523_DACR_VU;
> - wm8523->reg_cache[WM8523_DAC_CTRL3] |= WM8523_ZC;
> + reg_cache[WM8523_DAC_GAINR] |= WM8523_DACR_VU;
> + reg_cache[WM8523_DAC_CTRL3] |= WM8523_ZC;
All the drivers where you're making this substitution should in
principle be changed to use snd_soc_update_bits() since we now have
support for multiple cache memory formats so may not have this flat in
memory structure, though for the sake of getting the fixes in it's
probably best to ignore that and fix it up later.
next prev parent reply other threads:[~2010-12-24 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-24 13:47 [PATCH 0/9] ASoC: codecs: Fix register cache incoherencies Lars-Peter Clausen
2010-12-24 13:47 ` [PATCH 1/9] ASoC: codecs: Remove unused reg_cache fields from device structs Lars-Peter Clausen
2010-12-24 13:47 ` [PATCH 2/9] ASoC: codecs: max98088: Fix register cache incoherency Lars-Peter Clausen
2010-12-24 13:47 ` [PATCH 3/9] ASoC: codecs: wm8523: " Lars-Peter Clausen
2010-12-24 15:59 ` Mark Brown [this message]
2010-12-24 13:47 ` [PATCH 4/9] ASoC: codecs: wm8741: " Lars-Peter Clausen
2010-12-24 13:48 ` [PATCH 5/9] ASoC: codecs: wm8904: " Lars-Peter Clausen
2010-12-24 13:48 ` [PATCH 6/9] ASoC: codecs: wm8955: " Lars-Peter Clausen
2010-12-24 13:48 ` [PATCH 7/9] ASoC: codecs: wm8962: " Lars-Peter Clausen
2010-12-24 13:48 ` [PATCH 8/9] ASoC: codecs: wm9090: " Lars-Peter Clausen
2010-12-24 13:48 ` [PATCH 9/9] ASoC: codecs: wm8753: " Lars-Peter Clausen
2010-12-24 15:50 ` Mark Brown
2010-12-24 14:57 ` [PATCH 0/9] ASoC: codecs: Fix register cache incoherencies Mark Brown
2010-12-24 15:38 ` Lars-Peter Clausen
2010-12-24 16:14 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2010-12-28 20:37 [PATCH 0/9 v2] " Lars-Peter Clausen
2010-12-28 20:37 ` [PATCH 3/9] ASoC: codecs: wm8523: Fix register cache incoherency Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101224155929.GC16614@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=ian@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox