* [PATCH] coretemp: fix junction temperature for Intel CE4100
@ 2010-12-14 21:17 Florian Fainelli
2010-12-23 9:57 ` Florian Fainelli
2010-12-25 22:28 ` Yu, Fenghua
0 siblings, 2 replies; 4+ messages in thread
From: Florian Fainelli @ 2010-12-14 21:17 UTC (permalink / raw)
To: linux-kernel, Dirk Brandewie, sodaville, Fenghua Yu
From: Florian Fainelli <ffainelli@freebox.fr>
The Intel CE4100 System-on-a-Chip has a slightly higher junction temperature
(110 degrees Celsius) than other Atom-based hardware.
Cc: Dirk Brandewie <dirk.brandewie@gmail.com>
Cc: sodaville@linutronix.de
Cc: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
---
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 42de98d..e47b405 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -178,12 +178,23 @@ static int __devinit adjust_tjmax(struct cpuinfo_x86 *c, u32 id, struct device *
host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
- if (host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL
- && (host_bridge->device == 0xa000 /* NM10 based nettop */
- || host_bridge->device == 0xa010)) /* NM10 based netbook */
- tjmax = 100000;
- else
- tjmax = 90000;
+ if (host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL) {
+ switch (host_bridge->device) {
+ /* NM10 based nettop */
+ case 0xa000:
+ /* NM10 based netbook */
+ case 0xa010:
+ tjmax = 100000;
+ break;
+ /* IntelCE Sodaville (CE4100) */
+ case 0x0708:
+ tjmax = 110000;
+ break;
+ default:
+ tjmax = 90000;
+ break;
+ }
+ }
pci_dev_put(host_bridge);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] coretemp: fix junction temperature for Intel CE4100
2010-12-14 21:17 [PATCH] coretemp: fix junction temperature for Intel CE4100 Florian Fainelli
@ 2010-12-23 9:57 ` Florian Fainelli
2010-12-25 22:28 ` Yu, Fenghua
1 sibling, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2010-12-23 9:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Dirk Brandewie, sodaville, Fenghua Yu
On Tuesday 14 December 2010 22:17:07 Florian Fainelli wrote:
> From: Florian Fainelli <ffainelli@freebox.fr>
>
> The Intel CE4100 System-on-a-Chip has a slightly higher junction
> temperature (110 degrees Celsius) than other Atom-based hardware.
>
> Cc: Dirk Brandewie <dirk.brandewie@gmail.com>
> Cc: sodaville@linutronix.de
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
Fenghua, is there anything wrong with that patch? Thank you.
> ---
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 42de98d..e47b405 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -178,12 +178,23 @@ static int __devinit adjust_tjmax(struct cpuinfo_x86
> *c, u32 id, struct device *
>
> host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
>
> - if (host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL
> - && (host_bridge->device == 0xa000 /* NM10 based nettop */
> - || host_bridge->device == 0xa010)) /* NM10 based netbook */
> - tjmax = 100000;
> - else
> - tjmax = 90000;
> + if (host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL) {
> + switch (host_bridge->device) {
> + /* NM10 based nettop */
> + case 0xa000:
> + /* NM10 based netbook */
> + case 0xa010:
> + tjmax = 100000;
> + break;
> + /* IntelCE Sodaville (CE4100) */
> + case 0x0708:
> + tjmax = 110000;
> + break;
> + default:
> + tjmax = 90000;
> + break;
> + }
> + }
>
> pci_dev_put(host_bridge);
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] coretemp: fix junction temperature for Intel CE4100
2010-12-14 21:17 [PATCH] coretemp: fix junction temperature for Intel CE4100 Florian Fainelli
2010-12-23 9:57 ` Florian Fainelli
@ 2010-12-25 22:28 ` Yu, Fenghua
2010-12-27 10:04 ` Florian Fainelli
1 sibling, 1 reply; 4+ messages in thread
From: Yu, Fenghua @ 2010-12-25 22:28 UTC (permalink / raw)
To: Florian Fainelli, linux-kernel@vger.kernel.org, Dirk Brandewie,
sodaville@linutronix.de
> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@gmail.com] On Behalf Of
> Florian Fainelli
> Sent: Tuesday, December 14, 2010 1:17 PM
> To: linux-kernel@vger.kernel.org; Dirk Brandewie;
> sodaville@linutronix.de; Yu, Fenghua
> Subject: [PATCH] coretemp: fix junction temperature for Intel CE4100
>
> From: Florian Fainelli <ffainelli@freebox.fr>
>
> The Intel CE4100 System-on-a-Chip has a slightly higher junction
> temperature
> (110 degrees Celsius) than other Atom-based hardware.
>
> Cc: Dirk Brandewie <dirk.brandewie@gmail.com>
> Cc: sodaville@linutronix.de
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
> ---
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 42de98d..e47b405 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -178,12 +178,23 @@ static int __devinit adjust_tjmax(struct
> cpuinfo_x86 *c, u32 id, struct device *
>
> host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
>
> - if (host_bridge && host_bridge->vendor ==
> PCI_VENDOR_ID_INTEL
> - && (host_bridge->device == 0xa000 /* NM10 based
> nettop */
> - || host_bridge->device == 0xa010)) /* NM10 based
> netbook */
> - tjmax = 100000;
> - else
> - tjmax = 90000;
> + if (host_bridge && host_bridge->vendor ==
> PCI_VENDOR_ID_INTEL) {
> + switch (host_bridge->device) {
> + /* NM10 based nettop */
> + case 0xa000:
> + /* NM10 based netbook */
> + case 0xa010:
> + tjmax = 100000;
> + break;
> + /* IntelCE Sodaville (CE4100) */
> + case 0x0708:
> + tjmax = 110000;
> + break;
> + default:
> + tjmax = 90000;
> + break;
> + }
> + }
>
> pci_dev_put(host_bridge);
> }
When host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL is not true, tjmax is not assigned to 90000. This is different from original code.
Could you add public spec URL or public spec name for 110 degrees C in your comments? People may get lost to find this info.
Thanks.
-Fenghua
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] coretemp: fix junction temperature for Intel CE4100
2010-12-25 22:28 ` Yu, Fenghua
@ 2010-12-27 10:04 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2010-12-27 10:04 UTC (permalink / raw)
To: Yu, Fenghua
Cc: linux-kernel@vger.kernel.org, Dirk Brandewie,
sodaville@linutronix.de
Hello,
On Saturday 25 December 2010 23:28:33 Yu, Fenghua wrote:
> > -----Original Message-----
> > From: Florian Fainelli [mailto:f.fainelli@gmail.com] On Behalf Of
> > Florian Fainelli
> > Sent: Tuesday, December 14, 2010 1:17 PM
> > To: linux-kernel@vger.kernel.org; Dirk Brandewie;
> > sodaville@linutronix.de; Yu, Fenghua
> > Subject: [PATCH] coretemp: fix junction temperature for Intel CE4100
> >
> > From: Florian Fainelli <ffainelli@freebox.fr>
> >
> > The Intel CE4100 System-on-a-Chip has a slightly higher junction
> > temperature
> > (110 degrees Celsius) than other Atom-based hardware.
> >
> > Cc: Dirk Brandewie <dirk.brandewie@gmail.com>
> > Cc: sodaville@linutronix.de
> > Cc: Fenghua Yu <fenghua.yu@intel.com>
> > Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
> > ---
> > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > index 42de98d..e47b405 100644
> > --- a/drivers/hwmon/coretemp.c
> > +++ b/drivers/hwmon/coretemp.c
> > @@ -178,12 +178,23 @@ static int __devinit adjust_tjmax(struct
> > cpuinfo_x86 *c, u32 id, struct device *
> >
> > host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
> >
> > - if (host_bridge && host_bridge->vendor ==
> > PCI_VENDOR_ID_INTEL
> > - && (host_bridge->device == 0xa000 /* NM10 based
> > nettop */
> > - || host_bridge->device == 0xa010)) /* NM10 based
> > netbook */
> > - tjmax = 100000;
> > - else
> > - tjmax = 90000;
> > + if (host_bridge && host_bridge->vendor ==
> > PCI_VENDOR_ID_INTEL) {
> > + switch (host_bridge->device) {
> > + /* NM10 based nettop */
> > + case 0xa000:
> > + /* NM10 based netbook */
> > + case 0xa010:
> > + tjmax = 100000;
> > + break;
> > + /* IntelCE Sodaville (CE4100) */
> > + case 0x0708:
> > + tjmax = 110000;
> > + break;
> > + default:
> > + tjmax = 90000;
> > + break;
> > + }
> > + }
> >
> > pci_dev_put(host_bridge);
> >
> > }
>
> When host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL is not true,
> tjmax is not assigned to 90000. This is different from original code.
Whoops, I will post a second version of that patch.
>
> Could you add public spec URL or public spec name for 110 degrees C in your
> comments? People may get lost to find this info.
I will try to find a public documentation stating that, but that was in the SDK
we received and I could not find any public information about this yet.
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-27 10:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-14 21:17 [PATCH] coretemp: fix junction temperature for Intel CE4100 Florian Fainelli
2010-12-23 9:57 ` Florian Fainelli
2010-12-25 22:28 ` Yu, Fenghua
2010-12-27 10:04 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox