From: Grant Likely <grant.likely@secretlab.ca>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, qi.wang@intel.com,
yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com
Subject: Re: [PATCH 3/3] spi_topcliff_pch: fix resource leak issue
Date: Tue, 28 Dec 2010 23:51:44 -0700 [thread overview]
Message-ID: <20101229065144.GE8172@angua.secretlab.ca> (raw)
In-Reply-To: <1293449027-3219-3-git-send-email-tomoya-linux@dsn.okisemi.com>
On Mon, Dec 27, 2010 at 08:23:47PM +0900, Tomoya MORINAGA wrote:
> In case spi_register_master fails in probe function,
> pch_spi_free_resources is not called.
>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Ditto for patch 2. This looks like a bug fix, please respin to apply
without patch #1
Thanks,
g.
> ---
> drivers/spi/spi_topcliff_pch.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi_topcliff_pch.c b/drivers/spi/spi_topcliff_pch.c
> index a796eaf..e806e31 100644
> --- a/drivers/spi/spi_topcliff_pch.c
> +++ b/drivers/spi/spi_topcliff_pch.c
> @@ -1125,6 +1125,7 @@ static int pch_spi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> err_spi_reg_master:
> for (j = 0; j < i; j++)
> spi_unregister_master(master[j]);
> + pch_spi_free_resources(board_dat);
> err_spi_get_resources:
> err_spi_alloc_master:
> for (j = 0; j < i; j++)
> --
> 1.6.0.6
>
next prev parent reply other threads:[~2010-12-29 6:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 11:23 [PATCH 1/3] spi_topcliff_pch: support new device ML7213 Tomoya MORINAGA
2010-12-27 11:23 ` [PATCH 2/3] spi_topcliff_pch: change calling function order correctly in remove Tomoya MORINAGA
2010-12-27 11:23 ` [PATCH 3/3] spi_topcliff_pch: fix resource leak issue Tomoya MORINAGA
2010-12-29 6:51 ` Grant Likely [this message]
2010-12-29 6:51 ` [PATCH 2/3] spi_topcliff_pch: change calling function order correctly in remove Grant Likely
2010-12-29 6:49 ` [PATCH 1/3] spi_topcliff_pch: support new device ML7213 Grant Likely
2011-01-05 2:34 ` Tomoya MORINAGA
2011-01-05 16:38 ` Grant Likely
2011-01-07 6:40 ` Tomoya MORINAGA
2011-01-07 9:57 ` Milton Miller
[not found] ` <topcliff-split@mdm.bga.com>
2011-01-11 9:42 ` Tomoya MORINAGA
2011-01-12 5:27 ` Tomoya MORINAGA
2011-01-18 12:36 ` Tomoya MORINAGA
2011-01-19 6:25 ` Grant Likely
2011-01-07 6:47 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101229065144.GE8172@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=dbrownell@users.sourceforge.net \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox